Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editable non-satisfiable #1251

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

baszalmstra
Copy link
Contributor

@baszalmstra baszalmstra commented Apr 22, 2024

Fixes an issue where multiple requirements of editable/non-editable would conflict and cause the lock-file to be non satisfiable. However, the logic should be that if just one requirement specifies an editable install then it should be editable regardless of what other requirements specify.

You also get a nice error message:

expected bar, and foo to be editable but in the lock-file they are not, whereas baz is NOT expected to be editable which in the lock-file it is

Note that I also included several tests that test several cases.

@baszalmstra baszalmstra merged commit d3d251b into prefix-dev:main Apr 22, 2024
25 checks passed
@baszalmstra baszalmstra deleted the fix/editable_non_satisfiable branch April 22, 2024 13:53
tdejager pushed a commit to tdejager/pixi that referenced this pull request Apr 23, 2024
Fixes an issue where multiple requirements of editable/non-editable
would conflict and cause the lock-file to be non satisfiable. However,
the logic should be that if just one requirement specifies an editable
install then it should be editable regardless of what other requirements
specify.

You also get a nice error message:

```
expected bar, and foo to be editable but in the lock-file they are not, whereas baz is NOT expected to be editable which in the lock-file it is
```

Note that I also included several tests that test several cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants