Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to init with a pyproject.toml #1188

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

olivier-lacroix
Copy link
Contributor

Fixes #1177

/// The pyproject.toml template
///
/// This is used to create a pyproject.toml from scratch
const NEW_PYROJECT_TEMPLATE: &str = r#"[project]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure or what to include in that template. build-system, python version, etc.

Let me know what you think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know uv has a slower code path for it currently, but would hatch be a better option than setuptools?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. Setuptools seems to remain the most used today. https://framapiaf.org/@fcodvpt/111540079686191842

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's leave it.

@olivier-lacroix
Copy link
Contributor Author

Slightly related question: the import command initialise the prefix. This is currently the only branch that does this.

To be consistent, should we do it here as well (to install python)? Personally, I find it strange, and would rather pull out the prefix initialisation from the import branch

@tdejager
Copy link
Contributor

Yes! I ❤️ this thank you! With regards to your question I would keep this as you have now.

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruben-arts ruben-arts merged commit 48dbd17 into prefix-dev:main Apr 15, 2024
27 checks passed
@olivier-lacroix olivier-lacroix deleted the pyprojinit branch April 20, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pixi init pyproject.toml
3 participants