fix: Prevent duplicate direct dependencies in tree #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should keep `pixi tree` from displaying duplicate top level dependencies by filtering on Conda/PyPI sources. This doesn't handle mapping between Conda/PyPI names. fixes: prefix-dev#1158
|
Can you help me understand what is still missing in your opinion? I'm not sure what we would need the mapping for as the mapping is used to create the lock file. But This already looks good to me! Thanks for the fix. |
|
I don't know know enough about thorny mapping problems like the opencv/opencv-python issue you mentioned, to know if the tree is getting built wrong. I could see something like this rendering incorrectly, or at least not how I'd expect it to: [dependencies]
opencv = #...
[pypi-dependencies]
something-that-depends-on-opencv = #...But if you think this works, feel free to land it. |
ruben-arts
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should keep
pixi treefrom displaying duplicate top level dependencies by filtering on Conda/PyPI sources. This doesn't handle mapping between Conda/PyPI names.fixes: #1158