Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allowing solving for different platforms #1101

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

baszalmstra
Copy link
Contributor

Fixes #1082

Checking if the current machine meets the project requirements is only really required when using run or shell. This PR moves the logic to check if the system meets the minimum system requirements to those specific CLI commands. This allows you to create lock-files for other platforms than your own. (as long as you dont have pypi dependencies)

@baszalmstra baszalmstra changed the title fix: issue 1082 fix: allowing solving for different platforms Apr 2, 2024
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @baszalmstra

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @baszalmstra

@ruben-arts ruben-arts enabled auto-merge (squash) April 2, 2024 12:06
@ruben-arts ruben-arts disabled auto-merge April 2, 2024 13:05
@ruben-arts ruben-arts merged commit 6592e5f into prefix-dev:main Apr 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create a linux-64 environment from osx-arm64
3 participants