Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pickle compatible implementation of downsamplers #44

Merged
merged 3 commits into from
Apr 14, 2023
Merged

fix: pickle compatible implementation of downsamplers #44

merged 3 commits into from
Apr 14, 2023

Conversation

jonasvdd
Copy link
Member

@jonasvdd jonasvdd commented Apr 14, 2023 •
edited by jvdd
Loading

Closes #42

TODO:

  • tests
  • code reveiw

@jvdd jvdd changed the title 🔥 first pickle compatible implementation of downsamplers fix: pickle compatible implementation of downsamplers Apr 14, 2023
jvdd
jvdd approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@jvdd jvdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 14, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #44 pickle (3f714a0) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 390 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@jvdd jvdd merged commit 9297e50 into main Apr 14, 2023
@jvdd jvdd deleted the pickle branch April 14, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdd jvdd jvdd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: support serialization with pickle
2 participants
@jonasvdd @jvdd