fix: validate max_new_tokens against speculative_tokens during warmup (fixes #474) - #793
Open
mithilesh1909 wants to merge 1 commit into
Open
Conversation
…fixes predibase#474) Signed-off-by: mithilesh1909 <mittuayodhya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (fixes #474)
What does this PR do?
When speculative decoding is enabled, generating up to the model's max positional embeddings causes a CUDA device-side assert error at runtime. This PR adds an early validation check in the router that rejects requests where max_new_tokens + speculative_tokens would exceed the available token budget (max_total_tokens - input_length), returning a clear 422 error instead of crashing with a CUDA error.
Changes:
Fixes #474
Before submitting
to it if that's the case. Improve warmup checking for max new tokens when using speculative decoding #474
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.