Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service.loadBalancerIP #1

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

alexandre-abrioux
Copy link
Contributor

Hi! First of all, thanks for this awesome helm chart.
This PR adds the option to specify a loadBalancerIP for the service.
Thanks!

@alexandre-abrioux alexandre-abrioux force-pushed the loadBalancerIp branch 2 times, most recently from 1f03324 to dffb95a Compare December 11, 2021 14:30
@alexandre-abrioux
Copy link
Contributor Author

alexandre-abrioux commented Dec 11, 2021

@predatorray rebased the PR branch to the main branch

@alexandre-abrioux alexandre-abrioux changed the title Load balancer ip Add service.loadBalancerIP Dec 11, 2021
Copy link
Owner

@predatorray predatorray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for your contribution.

@predatorray predatorray merged commit 96bfda3 into predatorray:main Dec 16, 2021
@alexandre-abrioux alexandre-abrioux deleted the loadBalancerIp branch December 16, 2021 14:12
@predatorray
Copy link
Owner

This change has been published on the helm repository with version 0.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants