Dev new 1080p #10
Open
Dev new 1080p #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oser/sb-api/apibuilder > As this creates an bad scenario where an 1080p bluray appear as 'low quality' or even worse could get replaced by some crap mobile friendly release because of 'unkown' having a higher internal value. * Added 1080p aired, 1080p web-dl, 1080i/720p mpeg2 (Raw) qualities * Adjust CSS/sorting routines to reflect changes. * Added related CSS for quality tags * Added '.ts' to be assumed RawHD quality
…ich makes sense until the results contain more than the rss feed limit. If a show (ex: 'Terra Nova') has 10+ episodes.. so if each ep really came out in the 9 possible qualities (then there is also proper/repacks).. you can easily get over 50 results searching for the show name.. so I added a hack that restores using the S##E## if the show is only one season and has less than 11 episodes total.
…e quality chooser.
…ously used is no longer in SB/config.
…user 'default' quality along with migrating the previous qualities to their new values. Also PEP8 whitespace fixes.
… force Download quality. Tighten up check for HD TV and fix 1080p HD TV check @midgetspy - found bug in common.py **nameQuality** regex check does not work if one quality ('HD TV') is part of another quality ('1080p HD TV') thus it gets wrongly matched to (HD TV). For now I changed fullhdtv string to '1080p HDTV' to bypass this for now. Possible fix is to change 'HD TV' to '720p HD TV' so it follows similar naming of web-dl/bluray.. but the negative is that everyones previous names wouldnt be right/match/need to be updated... or we change how the regex matches...
…is actually used on SBConnect or any app for that matter.. so shouldn't break anything. > The SB quality templates can change and we do not want people submitting a template name but rather use the quality makeup. (ex, sdtv/sddvd for SD). This way it protects people from us changing things with the templates as the app coders can still just submit what they want SD to be / handle legacy qualities easier. (if sb.api = 3 then HD is this... if its 4 then HD is now this...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.