Upgrade to quasar 68.1.0 #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alissapajer
commented
Sep 14, 2018
| asData | ||
| }) | ||
|
|
||
| stream.map(_.handleErrorWith { |
There was a problem hiding this comment.
We might want to still handle errors like this. Let me see what jawnfs2 does with errors.
jsantos17
reviewed
Sep 15, 2018
There was a problem hiding this comment.
Unfortunately it seems like there's some sort of binary incompatibility with the newly introduced QData. Stack trace.
I'm not familiar with QData but this seems like a mismatched dependency.
|
@alissapajer @djspiewak Tried it with |
|
It's because quasar hasn't been updated to 2.1.0 in the version depended upon by this PR. |
jsantos17
approved these changes
Sep 15, 2018
There was a problem hiding this comment.
We just need to merge the PR bumping to 68.2.0 as soon as @slamdata-bot opens it.
Merged
jsantos17
added a commit
that referenced
this pull request
Sep 15, 2018
(Merge branch 'djspiewak-update-quasar') This is an extension of #166.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ch1981]
[ch1968]