Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libvirt support #25

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Add libvirt support #25

merged 2 commits into from
Apr 13, 2022

Conversation

fsimonis
Copy link
Member

This PR adds a libvirt box to the preCICE VM.

The workflow is currently untested.

@fsimonis fsimonis marked this pull request as ready for review February 10, 2022 14:47
@fsimonis
Copy link
Member Author

I was able to build this box locally after applying #28.
Without the patch, I ran repeatedly into download issues with the OpenFOAM packages

@fsimonis
Copy link
Member Author

New issue. The libvirt provider is not available on windows.
So we need self-hosted runners here.

@fsimonis
Copy link
Member Author

fsimonis commented Mar 23, 2022 •
edited
Loading

Looks like enabling libvirt on macOS is not as easy as I initially thought.
This workflow would be a good candidate for a self-hosted runner.

Anyhow, there is functionally no difference between the virtualbox and the libvirt-box.
We could switch the image and then build the libvirt-box manually until we have a self-hosted runner.

@MakisH I propose to clean this PR up, and merge it to at least allow creating the libvirt version locally. Is this fine with you?

MakisH
MakisH reviewed Mar 23, 2022
View reviewed changes
@MakisH
Copy link
Member

MakisH commented Mar 23, 2022

I would first like some more detailed comparison between bento/ubuntu-20.04 and generic/ubuntu2004, as this a fundamental change that can have side-effects.

Other than that, I am fine merging the rest.

@fsimonis
Copy link
Member Author

I pulled the latest boxes and created diffable package lists of bento and generic.

The sources for the bento and the generic box are open.

The generic image is slightly smaller, but my guess is that this doesn't really matter once we install all the basics.

MakisH
MakisH approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@MakisH MakisH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aright, then let's merge it. I don't see any package that we need and would not anyway be installed, I don't know if there are any differences in configuration that we should consider, but let's find out.

Do you also need a release on Vagrant Cloud for any reason?

Please check my review comments above before merging.

MakisH
MakisH reviewed Mar 29, 2022
View reviewed changes
@MakisH MakisH changed the base branch from main to develop April 13, 2022 06:32
@MakisH MakisH merged commit 6de64c3 into develop Apr 13, 2022
@MakisH MakisH deleted the libvirt-support branch April 13, 2022 06:33
@MakisH MakisH mentioned this pull request Jul 24, 2022
Merged
@MakisH MakisH mentioned this pull request Oct 11, 2022
Open
This was referenced Apr 17, 2024
Merged
Closed
@fsimonis
Copy link
Member Author

The bento box for ubuntu 24.04 now supports libvirt and virtualbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakisH MakisH MakisH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsimonis @MakisH