Add rust elastic-tube-1d solvers #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uekerman
reviewed
Mar 15, 2023
uekerman
reviewed
Mar 19, 2023
| license = "LGPL-3.0-or-later" | ||
|
|
||
| [dependencies] | ||
| "precice" = "2.5" |
There was a problem hiding this comment.
This tutorial requires preCICE v3 to run since the precice-config.xml requires it. How did you run it?
There was a problem hiding this comment.
Have we already upgraded the tutorials? This one is still based on precice version 2.5.0.
There was a problem hiding this comment.
Tutorials are as much as possible in synch with preCICE. This one also requires the develop branch, e.g.
tutorials/elastic-tube-1d/precice-config.xml
Lines 22 to 23 in 5839e2c
|
This PR is superseeded by #435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rust variants of the elastic-tube-1d solvers.
To run, install preCICE and cargo (the Eierlegendewollmilchsau of rust), and finally run
./run.sh.Cargo will fetch dependencies, compile everything in release mode and run the solver for you.