Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation hints for mesh connectivity #233

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Add implementation hints for mesh connectivity #233

merged 4 commits into from
Feb 27, 2023

Conversation

fsimonis
Copy link
Member

@fsimonis fsimonis commented Dec 8, 2022

This PR adds hints for mesh connectivity implementation in adapters.

Feedback is highly appreciated.

@MakisH MakisH self-requested a review December 8, 2022 16:11
MakisH
MakisH reviewed Dec 12, 2022
View reviewed changes
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Outdated Show resolved Hide resolved
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Show resolved Hide resolved
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Outdated Show resolved Hide resolved
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Outdated Show resolved Hide resolved
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Outdated Show resolved Hide resolved
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Outdated Show resolved Hide resolved
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Outdated Show resolved Hide resolved
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Outdated Show resolved Hide resolved
@fsimonis
Copy link
Member Author

I completely modified the new section and added examples for every case.
Does this look more understandable?

MakisH
MakisH reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed reads more clearly. I still don't really understand the labels case, though.

pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Outdated Show resolved Hide resolved
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Outdated Show resolved Hide resolved
pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Show resolved Hide resolved
@fsimonis fsimonis requested a review from MakisH January 20, 2023 12:04
MakisH
MakisH approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through everything again (the complete page), it makes total sense. 👍

pages/docs/couple-your-code/couple-your-code-defining-mesh-connectivity.md Show resolved Hide resolved
@fsimonis fsimonis merged commit ed1e763 into master Feb 27, 2023
@fsimonis fsimonis deleted the extend-mesh-connectivity branch February 27, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakisH MakisH MakisH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsimonis @MakisH