Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos #187

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Fix various typos #187

merged 1 commit into from
Jul 27, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jul 27, 2022

No description provided.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🤗 All the changes look indeed like simple typo fixes that only help, without breaking anything.

@MakisH MakisH merged commit ee70b1d into precice:master Jul 27, 2022
@@ -158,7 +158,7 @@ Surface mesh consisting of vertices and (optional) of edges and triangles (only
| Attribute | Type | Description | Default | Options |
| --- | --- | --- | --- | --- |
| name | string | Unique name for the mesh. | _none_ | none |
| flip-normals | boolean | Deprectated. | `0` | none |
| flip-normals | boolean | Deprecated. | `0` | none |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a typo in the main repo, as the xmlreference is autogenerated by preCICE.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that. Here, it does not matter, as it will get updated anyway by the next submodule update. Feel free to update in preCICE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants