-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information on the Julia bindings #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 😄
I did not install and run, but I could at least trigger the package installation (I would need to switch to preCICE v2.4.0, first, which I don't want to do at the moment). If you want me to also test this, just ask and I will do it.
I only have tiny language suggestions and a couple of minor edits.
Great documentation!
pages/docs/couple-your-code/couple-your-code-preparing-your-solver.md
Outdated
Show resolved
Hide resolved
…lver.md Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I did not go into super detail as I already refined all of this with @erikscheurer in the original README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot! 😄
Before merging, could you please also describe here in a comment how the Julia bindings would fit in the bindings architecture figure? I can then update this picture in a future PR.
Maybe @IshaanDesai can help me out here, I'm not 100% sure how the architecture fits in here. |
So, you only link to the library, without including any headers, and use the C interface. This is enough for me to draw it, thanks! 👍 |
See #202 |
The Julia bindings are now released. This PR adds information on installation and uses to the preCICE website.