Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information on the Julia bindings #171

Merged
merged 7 commits into from
Aug 16, 2022

Conversation

erikscheurer
Copy link
Contributor

The Julia bindings are now released. This PR adds information on installation and uses to the preCICE website.

@IshaanDesai IshaanDesai requested review from MakisH and IshaanDesai May 28, 2022 19:47
@erikscheurer erikscheurer self-assigned this May 29, 2022
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 😄

I did not install and run, but I could at least trigger the package installation (I would need to switch to preCICE v2.4.0, first, which I don't want to do at the moment). If you want me to also test this, just ask and I will do it.

I only have tiny language suggestions and a couple of minor edits.

Great documentation!

pages/docs/installation/installation-bindings-julia.md Outdated Show resolved Hide resolved
pages/docs/installation/installation-bindings-julia.md Outdated Show resolved Hide resolved
pages/docs/installation/installation-bindings-julia.md Outdated Show resolved Hide resolved
pages/docs/installation/installation-bindings-julia.md Outdated Show resolved Hide resolved
pages/docs/installation/installation-bindings-julia.md Outdated Show resolved Hide resolved
pages/docs/installation/installation-bindings-julia.md Outdated Show resolved Hide resolved
pages/docs/installation/installation-bindings-julia.md Outdated Show resolved Hide resolved
erikscheurer and others added 4 commits August 15, 2022 12:12
…lver.md

Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
@erikscheurer erikscheurer requested a review from MakisH August 15, 2022 10:29
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I did not go into super detail as I already refined all of this with @erikscheurer in the original README.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot! 😄

Before merging, could you please also describe here in a comment how the Julia bindings would fit in the bindings architecture figure? I can then update this picture in a future PR.

@erikscheurer
Copy link
Contributor Author

Maybe @IshaanDesai can help me out here, I'm not 100% sure how the architecture fits in here.
With the Julia bindings we make a call to the C library libprecice.so (literally ccall). As far as I can see we have no explicit connection to any C++ header or something, only what the library provides.

@MakisH
Copy link
Member

MakisH commented Aug 16, 2022

Maybe @IshaanDesai can help me out here, I'm not 100% sure how the architecture fits in here. With the Julia bindings we make a call to the C library libprecice.so (literally ccall). As far as I can see we have no explicit connection to any C++ header or something, only what the library provides.

So, you only link to the library, without including any headers, and use the C interface. This is enough for me to draw it, thanks! 👍

@MakisH MakisH merged commit fe46343 into precice:master Aug 16, 2022
@MakisH
Copy link
Member

MakisH commented Aug 16, 2022

See #202

@erikscheurer erikscheurer deleted the julia-bindings branch August 16, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants