Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Font Awesome to 5.14.0 #1

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Upgrade Font Awesome to 5.14.0 #1

merged 2 commits into from
Sep 25, 2020

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Sep 24, 2020

This upgrades Font Awesome from version 4.7.0 to 5.14.0, giving us access to more and better free icons.

@chlorenz I still cannot figure out the external link icon (see review) and I a hope I have not missed any icons.

@MakisH MakisH requested a review from chlorenz September 24, 2020 09:39
Comment on lines 932 to 933
content: "\f35d";
font-family: "Font Awesome 5 Free Solid";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that these are the changes needed to upgrade the external link icon from version 4 to version 5, but it does not work for me. Any ideas?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out there is a "known issue" in FontAwesome 5: FortAwesome/Font-Awesome#11946
To use Unicode code points the font-family has to be "Font Awesome\ 5 Free" and you have to set font-weight: 900 manually.
Credits go to https://stackoverflow.com/questions/17254339/font-awesome-unicode

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... Then good thing I did not spend any more time on this crazy bug. 😅 Thanks a lot!

This was referenced Sep 24, 2020
Comment on lines 932 to 933
content: "\f35d";
font-family: "Font Awesome 5 Free Solid";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out there is a "known issue" in FontAwesome 5: FortAwesome/Font-Awesome#11946
To use Unicode code points the font-family has to be "Font Awesome\ 5 Free" and you have to set font-weight: 900 manually.
Credits go to https://stackoverflow.com/questions/17254339/font-awesome-unicode

@chlorenz chlorenz merged commit 8419869 into master Sep 25, 2020
@MakisH MakisH deleted the font-awesome-5 branch April 15, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants