Add a Fluid-Fluid module #67

MakisH · 2019-02-06T15:14:59Z

This Pull Request adds a simple Fluid-Fluid module.

I have currently implemented reading and writing pressures and velocities, but I have not yet tested it.

See issue #60.

The case is currently ill-defined.

Also fix bugs (typos) in PressureGradient. The tutorial case is still ill-defined.

Still ill-defined. Cylindrical mesh from https://github.com/MakisH/openfoam_bubble_column/tree/master/short_bubbleFoam_da3_Ua02

viscosity

Some parameters (especially in the thermodynamicProperties files) are completely abitrary, copied from the OpenFOAM 5 bundled tutorial for sonicLiquidFoam.

Updates for: - preCICE v2 - preciceDict replacing precice-adapter-config.yml - ability to act as a 2D solver - mesh connectivity and more. Some indentation issues came up during merging, most of the code should be consistent now.

FF/FF.C

MakisH

Looking at this code after several months and it looks like we can change a few things.

tutorials/FF/pipe-pipe/sonicLiquidFoam-sonicLiquidFoam/precice-config.xml

tutorials/FF/pipe-pipe/pimpleFoam-pimpleFoam/Fluid1/constant/transportProperties

FF/FF.C

uekerman

I added a few tweaks to the sonicLiquidFoam case. Now, both cases converge nicely.
There are many white-space changes. Where do they come from and do we want to keep them?

tutorials/FF/pipe-pipe/pimpleFoam-pimpleFoam/precice-config.xml

tutorials/FF/pipe-pipe/sonicLiquidFoam-sonicLiquidFoam/precice-config.xml

MakisH · 2020-07-29T08:56:54Z

@uekerman In my local copy I had cleaned up the case files, I will clean them again.

There are indeed many whitespace changes, but I plan to work on #126 soon afterwards, as right now out formatting is quite inconsistent and we will have similar problems later on.

…-config.xml Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>

Co-authored-by: Benjamin Uekermann <benjamin.uekermann@gmail.com>

MakisH · 2020-07-29T18:27:15Z

This is now ready enough to merge to develop, so that we are able to built upon it. Thank you both for the reviews!

FrankyOpenFOAM · 2022-05-04T14:56:57Z

Hello, in system file, there is a "precicedict". In precicedict, there is a interface, which is used to determine patch to transfer the data. But in my work, I want to transfer all of my data in whole computational domain to other openfoam solver. Do you know if there is a way to do this?

MakisH · 2022-05-04T15:29:42Z

What you want to do is what we refer to as "volume coupling". A few people have tried this already (e.g., #183, #182, #181) and we are working to implement this properly and fully in the adapter.

MakisH added 8 commits February 6, 2019 15:01

Add Fluid-Fluid module main files and Velocity

08e1e0a

Use the Fluid-Fluid module in the Adapter

703e5fc

Update README.md

f7b2971

Fix: velocity should be vector, not scalar

328265f

FluidFluid: Add Pressure

73a3ef9

FF: Fix IF in adding readers/writers

02e1673

FF: Update reading velocities for readability

3a3c300

Add 1-way Fluid-Fluid tutorial case

cf11641

MakisH requested a review from uekerman February 7, 2019 15:38

MakisH self-assigned this Feb 7, 2019

MakisH added 10 commits March 18, 2019 09:18

Merge branch 'master' into FF

ec07e67

FF Tutorial Allclean: Remove .json files

3583f77

Add PressureGradient in the FF module

21da7cf

Add PressureGradient in the FF tutorial

ba0e029

The case is currently ill-defined.

Add VelocityGradient

5b2b9c2

Also fix bugs (typos) in PressureGradient. The tutorial case is still ill-defined.

Convert tutorial to a cylinder

3276414

Still ill-defined. Cylindrical mesh from https://github.com/MakisH/openfoam_bubble_column/tree/master/short_bubbleFoam_da3_Ua02

FF tutorial: simplify blockMeshDict

4abaefd

FF Tutorial: couple p and U, use inflow/outflow BC

196833e

FF Tutorial: add implicit coupling config

e417752

FF: Fix bug in gradient writing

2f9c957

MakisH mentioned this pull request Mar 24, 2019

write-data should be independent from the boundary condition #77

Open

uekerman and others added 7 commits March 29, 2019 12:22

modified fluid-fluid tutorial: exchange of gradients and higher

ba86efe

viscosity

Make the adapter compatible with new pkg-config

e25a202

Add pkgconfig LIBS, remove unnecessary system flags

cb66b5c

Merge FF local and remote

37d655e

Add FF tutorial with sonicLiquidFoam

878313d

Some parameters (especially in the thermodynamicProperties files) are completely abitrary, copied from the OpenFOAM 5 bundled tutorial for sonicLiquidFoam.

FF: Add parallel versions of tutorials

857f18c

Adapt FF tutorials Allclean scripts for preCICE v1.6.0

739323c

MakisH added the FF Fluid-fluid coupling label Feb 25, 2020

Merge branch 'master' into FF

e517609

Updates for: - preCICE v2 - preciceDict replacing precice-adapter-config.yml - ability to act as a 2D solver - mesh connectivity and more. Some indentation issues came up during merging, most of the code should be consistent now.