Skip to content

Avoid ambiguous type conversion when accessing tmp<vectorField> #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MakisH merged 4 commits into from
Apr 7, 2025
Merged

Avoid ambiguous type conversion when accessing tmp<vectorField> #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
331e389
Avoid ambiguous type conversion when accessing tmp<vectorField>
MakisH Mar 21, 2025
d418ef7
Add changelog entry
MakisH Mar 21, 2025
131edd7
Update preCICE reference for system tests
MakisH Mar 21, 2025
dfb9528
Merge branch 'develop' into cref
MakisH Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FF/BoundaryConditions/coupledPressure/coupledPressureFvPatchField.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ void Foam::coupledPressureFvPatchField::updateCoeffs()
const scalarField& phip = phi->boundaryField()[this->patch().index()];
const Foam::volVectorField* U = &db().lookupObject<volVectorField>(uName_);
const vectorField& Up = U->boundaryField()[this->patch().index()];
const vectorField n = this->patch().nf();
const vectorField n = this->patch().nf().cref();

int t0 = this->patch().boundaryMesh().mesh().time().startTimeIndex();
int t = this->patch().boundaryMesh().mesh().time().timeIndex();
Expand Down
2 changes: 1 addition & 1 deletion FF/BoundaryConditions/coupledVelocity/coupledVelocityFvPatchField.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ void Foam::coupledVelocityFvPatchField::updateCoeffs()
}
const Foam::surfaceScalarField* phi = &db().lookupObject<surfaceScalarField>(phiName_);
const scalarField& phip = phi->boundaryField()[this->patch().index()];
const vectorField n = this->patch().nf();
const vectorField n = this->patch().nf().cref();

int t0 = this->patch().boundaryMesh().mesh().time().startTimeIndex();
int t = this->patch().boundaryMesh().mesh().time().timeIndex();
Expand Down
2 changes: 1 addition & 1 deletion FF/Velocity.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ std::size_t preciceAdapter::FF::Velocity::write(double* buffer, bool meshConnect
if (fluxCorrection_)
{
scalarField phip = phi_->boundaryFieldRef()[patchID];
vectorField n = U_->boundaryField()[patchID].patch().nf();
const vectorField n = U_->boundaryField()[patchID].patch().nf().cref();
const scalarField& magS = U_->boundaryFieldRef()[patchID].patch().magSf();
UPatch = UPatch - n * (n & U_->boundaryField()[patchID]) + n * phip / magS;
}
Expand Down
1 change: 1 addition & 0 deletions changelog-entries/358.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixed an issue preventing compiling the adapter with the Intel compiler [#358](https://github.com/precice/openfoam-adapter/pull/358).