Avoid ambiguous type conversion when accessing tmp<vectorField>

.github/workflows/system-tests.yaml

@@ -24,6 +24,6 @@ jobs:
     uses: precice/tutorials/.github/workflows/run_testsuite_workflow.yml@develop
     with:
       suites: openfoam_adapter_pr
-      build_args: TUTORIALS_REF:${{ needs.gather-refs.outputs.reftutorials }},PRECICE_REF:v3.1.1,OPENFOAM_EXECUTABLE:openfoam2312,OPENFOAM_ADAPTER_REF:${{ github.event.pull_request.head.sha }}
+      build_args: TUTORIALS_REF:${{ needs.gather-refs.outputs.reftutorials }},PRECICE_REF:aeb0f6f,OPENFOAM_EXECUTABLE:openfoam2312,OPENFOAM_ADAPTER_REF:${{ github.event.pull_request.head.sha }}
       systests_branch: develop
       loglevel: "DEBUG"

FF/BoundaryConditions/coupledPressure/coupledPressureFvPatchField.C

@@ -99,7 +99,7 @@ void Foam::coupledPressureFvPatchField::updateCoeffs()
     const scalarField& phip = phi->boundaryField()[this->patch().index()];
     const Foam::volVectorField* U = &db().lookupObject<volVectorField>(uName_);
     const vectorField& Up = U->boundaryField()[this->patch().index()];
-    const vectorField n = this->patch().nf();
+    const vectorField n = this->patch().nf().cref();
 
     int t0 = this->patch().boundaryMesh().mesh().time().startTimeIndex();
     int t = this->patch().boundaryMesh().mesh().time().timeIndex();

FF/BoundaryConditions/coupledVelocity/coupledVelocityFvPatchField.C

@@ -95,7 +95,7 @@ void Foam::coupledVelocityFvPatchField::updateCoeffs()
     }
     const Foam::surfaceScalarField* phi = &db().lookupObject<surfaceScalarField>(phiName_);
     const scalarField& phip = phi->boundaryField()[this->patch().index()];
-    const vectorField n = this->patch().nf();
+    const vectorField n = this->patch().nf().cref();
 
     int t0 = this->patch().boundaryMesh().mesh().time().startTimeIndex();
     int t = this->patch().boundaryMesh().mesh().time().timeIndex();

FF/Velocity.C

@@ -92,7 +92,7 @@ std::size_t preciceAdapter::FF::Velocity::write(double* buffer, bool meshConnect
         if (fluxCorrection_)
         {
             scalarField phip = phi_->boundaryFieldRef()[patchID];
-            vectorField n = U_->boundaryField()[patchID].patch().nf();
+            const vectorField n = U_->boundaryField()[patchID].patch().nf().cref();
             const scalarField& magS = U_->boundaryFieldRef()[patchID].patch().magSf();
             UPatch = UPatch - n * (n & U_->boundaryField()[patchID]) + n * phip / magS;
         }

changelog-entries/358.md

@@ -0,0 +1 @@
+- Fixed an issue preventing compiling the adapter with the Intel compiler [#358](https://github.com/precice/openfoam-adapter/pull/358).