Skip to content

Add curly braces to one-line if blocks #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2021
Merged

Add curly braces to one-line if blocks #175

merged 1 commit into from
Apr 29, 2021

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Apr 29, 2021

Closes #174.

@davidscn please have a look at the diff and merge if it looks reasonable.

@MakisH MakisH added the dev Not directly affecting users, but helping future development label Apr 29, 2021
@MakisH MakisH requested a review from davidscn April 29, 2021 08:08
@MakisH MakisH added this to the v1.0.0 milestone Apr 29, 2021
davidscn
davidscn reviewed Apr 29, 2021
View reviewed changes
Copy link
Member

@davidscn davidscn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somehow necessary forclang-format, right? Usually clang should realize that you skipped the brackets and indentation should be correct. What am I missing here?

@MakisH
Copy link
Member Author

MakisH commented Apr 29, 2021

This is somehow necessary forclang-format, right? Usually clang should realize that you skipped the brackets and indentation should be correct. What am I missing here?

It is not due to formatting, I just noticed that we had this maintainability problem after formatting, which could happen also without formatting. See #174 for the reasoning.

davidscn
davidscn approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@davidscn davidscn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't went through all the remaining code, but looks good so far.

@MakisH MakisH merged commit ec9e454 into develop Apr 29, 2021
@MakisH MakisH deleted the fix-174 branch April 29, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidscn davidscn davidscn approved these changes

Assignees
No one assigned
Labels
dev Not directly affecting users, but helping future development
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MakisH @davidscn