-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshot computation #101
Snapshot computation #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some open questions and restructuring of postprocessing is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work already 👏 My suggestions are fundamental and hence require some discussion before large implementation changes. Let us discuss here in the comments.
For large parameter spaces, we need to think about chunking. Everything I have found suggests that, within a dataset, all chunks must have the same size, which complicates matters. A poor choice of chunk size can lead, besides other effects, to files containing empty allocated space. Not knowing the dimensions of a snapshot also complicates finding an optimal chunk size. As subfiling is currently not supported in |
This sounds like sth we should better hide from the user. |
c0904b1
to
a26b44a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 this is close to merging now. Lets resolve some last comments. Please also remember that documentation for snapshot computation needs to be added. As discussed earlier, we can do this in a separate pull request.
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Partly implementation of snapshot features discussed in #89. This does not yet include the configuration of the parameter space at runtime and a callback interface to invoke postprocessing as discussed in SimTech project PN5-9(II).
Reading parameter information from an hdf5 file and writing snapshot outputs to hdf5 files and the project structure might need more work.