Introduce mock testing #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
changed the title
v3.0.0
khalilhkiri
changed the title
v3.0.0v3.1.2
khalilhkiri
force-pushed
the
develop
branch
3 times, most recently
from
e7aaa32 to
198c0ee
Compare
There was a problem hiding this comment.
I factored out #33 from this PR to avoid mixing the mocking (which is still WIP and probably needs some time) with the upgrade to preCICE v3 (which is pretty much ready to merge).
Regarding the mocking: General approach looks good.
Will briefly summarize what todos we discussed yesterday in order to keep @IshaanDesai in the loop:
- put mocked implementation into dedicated folder (e.g.
testing/mock/fluent) - split
mockedFluent.cintotesting/mock/fluent/udf.handtesting/mock/fluent/dynamesh_tools.h - automatize selection of mocked vs. non-mocked Fluent. There are two possible approaches:
- Use macros to switch between the real
#include "udf.h"and the mocked#include "testing/mock/fluent/udf.h". - Always use
#include "udf.h"and pick the real/mocked version by selecting the respectivemakefilewith the corresponding include paths.
- Use macros to switch between the real
@khalilhkiri please comment if I forgot any important points.
BenjaminRodenberg
changed the title
v3.1.2
|
Shall I have a look or this is still WIP? |
|
it s still WIP, needs some more adjustments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.