-
-
Notifications
You must be signed in to change notification settings - Fork 17
Reviving adapter to a working state with Fluent version 21.2.0 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added Constants.h and SolverInterfaceC.h into the adapter
Added Constants.h and SolverInterfaceC.h into the adapter
This reverts commit defc14d.
This reverts commit f20545a.
…18.2. Main changes: Makefiles and user.udf as source specification, changes in api beacuse of name changes
…18.2. Main changes: Makefiles and user.udf as source specification, changes in api beacuse of name changes
…18.2. Main changes: Makefiles and user.udf as source specification, changes in api beacuse of name changes
…into update_fluent191
…into update_fluent191
…structure requirement
…structure requirement
…le process includes proper paths and manual copy of these files is not necessary
Need to handle a small dt updating bug tomorrow
…dates to scheme and udf scripts; still need to work through fsi_grid_motion becuase the skip_grid_motion variable breaks communication to the host
…ve time stepping; getting an error where preCICE complains about being passed NaN or Inf forces
…of distance between coupling meshes
… to make sure everything is working corectly
This pull request has been mentioned on preCICE Forum on Discourse. There might be relevant details there: https://precice.discourse.group/t/state-documentation-of-the-fluent-adapter-examples-cavity2d/1692/2 |
@@ -0,0 +1,10 @@ | |||
; commands to send to Fluent to initialize and solve FSI analysis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A README.md
file here would be very helpful.
examples/Cavity2D 。 I'm not familiar with Python, so I would like to know how to use CSMdummy.py. Thank you very much |
Hi @vierousa, The file The Cavity2D example does not have documentation of its own, but all the necessary files are arranged in a way that you can refer to the How to start Fluent section of the repository README, and run the case using the instructions in there. I know this is not ideal, but this is work in progress still. Please let us know if you face further issues in running the Cavity2D example. |
There has been significant interest in the adapter recently, and the branch of this PR is the closest working state, and also fairly documented. I propose merging this pull request and continuing development on the develop branch, mainly to prevent the use of a feature branch as a develop branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as this helps further development, I am happy to see it merged! 🚀
I have no idea about any licensing issues, please confirm before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also sounds like a good approach to me. Let's merge this one as it has de-facto become the develop branch anyways 😏
This PR consists of a wide range of modifications to the legacy version of the adapter to revive it and get it to work with Fluent version 21.2.0. A working state of the adapter was achieved by @mtree22 recently.
The goal of this PR is to polish the adapter code and documentation and push a working and well-documented state to the develop branch, from which eventually a new adapter can be released.
@mtree22 lets use this PR to work on the tasks that we discussed.