-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use precice develop for tests #49
Conversation
At the moment, only the build test uses precice develop, this can easily be added, but may be open for debate as the python bindings to my understanding also use the docker container to test the solver dummies. The solverdummies would be the only test affected by this, as the others use a dummy solverinterface. |
We are now facing the issue, that the tests would run fine, but the versions of julia are outdated in a way, that leads the version of |
I do not fully understand what can be a solution here. Are you suggesting that we drop support for older Julia versions? The test failures seem to not be related to Julia versions, because some tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 please squash and merge.
This PR modifies the tests to build precice develop instead of using the latest precice docker container as discussed in #47.