Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use precice develop for tests #49

Merged
merged 29 commits into from
Mar 14, 2023
Merged

Use precice develop for tests #49

merged 29 commits into from
Mar 14, 2023

Conversation

erikscheurer
Copy link
Contributor

This PR modifies the tests to build precice develop instead of using the latest precice docker container as discussed in #47.

@erikscheurer
Copy link
Contributor Author

At the moment, only the build test uses precice develop, this can easily be added, but may be open for debate as the python bindings to my understanding also use the docker container to test the solver dummies. The solverdummies would be the only test affected by this, as the others use a dummy solverinterface.

@erikscheurer
Copy link
Contributor Author

We are now facing the issue, that the tests would run fine, but the versions of julia are outdated in a way, that leads the version of libstdc++ being newer in the container that we use (ubuntu-latest) than the ones shipped with julia.
This error has been discussed in #44 and is now included in the julia bindings readme. It could be solved by preloading the system libraries, or by upgrading to newer julia versions compared to the system.

@IshaanDesai
Copy link
Member

We are now facing the issue, that the tests would run fine, but the versions of julia are outdated in a way, that leads the version of libstdc++ being newer in the container that we use (ubuntu-latest) than the ones shipped with julia. This error has been discussed in #44 and is now included in the julia bindings readme. It could be solved by preloading the system libraries, or by upgrading to newer julia versions compared to the system.

I do not fully understand what can be a solution here. Are you suggesting that we drop support for older Julia versions? The test failures seem to not be related to Julia versions, because some tests for 1.6.0 pass and others fail.

@erikscheurer
Copy link
Contributor Author

These changes break the tests on develop, but this should be fixed with #47.
Due to older LTS versions of Julia, we have to preload libstdc++ and libcurl as described in #44 and now the README.

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 please squash and merge.

@erikscheurer erikscheurer changed the title Compile build test from precice develop Use precice develop for tests Mar 14, 2023
@erikscheurer erikscheurer merged commit 176cbb3 into develop Mar 14, 2023
@erikscheurer erikscheurer deleted the test-use-develop branch March 14, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants