Remove meshName from arguments #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshaanDesai
approved these changes
May 15, 2022
erikscheurer
added a commit
that referenced
this pull request
May 21, 2022
* Change version * Correct TagBot * Try _ to seperate PreCICE from bindings version * Seperate bindings version with a `-` * Change version to release candidate `2.4.0-0-rc1` * Add formatter workflow (#31) * Update README * Add formatter workflow * Format every current file * New line at the end of the file * Revert README changes * Run format on each push on all branches * Update README with general repository and troubleshooting (#30) * Update README * Minor edits to README Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Fix bug: readScalarData returns wrong value (#33) * Fix wrong transposes (#35) * Add tests for Package functions (#32) * Update README * Add formatter workflow * Format every current file * New line at the end of the file * Revert README changes * Run format on each push on all branches * [WIP] Set up testing for all functions * [WIP] Set up testing for all functions * Correct some errors and types * Use string compare and debugging * Debugging * Undo Integer convert * Don't use range for 1.6 compat * integer to Cint * Merge develop into testing * Seperate Functioncall tests * Add info message where to run `make` * Format * Move function tests back to the rest * Undo documentation changes for now unchanged functions * Add user info where to run `make` * Update test workflow to include function tests * Undo changes to workflow and Fix runtests * Update Readme * Test excluding julia x86 architecture * Test running tests manually * Undo workflow changes * Compile Fake solverdummy * Install make in workflow * no sudo * make instead of build essential * update and apt * Add info on how to compile fake SolveIinterface.c * Change command in user info * Update README.md Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Update README.md Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Review Changes Co-authored-by: Ishaan Desai <ishaandesai@gmail.com> * Remove meshName from arguments (#36) * Remove meshName from arguments * Remove MeshName from solverdummy test * Format * Fix tests (#37) * Fix tests * Remove unecessary comment * Update version number Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mesh name was removed from the input arguments to the other solverdummies in precice/precice#1256. The change is now incorporated in the solverdummy in this repository for consistency.