Change PREBUILD_STRIP_BIN to path to strip binary #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The strip binary wasn't found when we looked in the expected location: `/usr/arm-linux-gnueabihf/bin/arm-linux-gnueabihf-strip`. It's unclear why this is happening, but we need to change the environment variable `PREBUILD_STRIP_BIN` so that it points at a valid binary. Solution: We found three binaries that seem to look like `strip`: - /usr/arm-linux-gnueabihf/bin/strip - /usr/bin/arm-linux-gnueabihf-strip - /usr/bin/x86_64-linux-gnu-strip The first two are the exact same binary, confirmed with `sha256sum`, and since their version string contains "crosstool" I'm guessing that they're the right binary. Since both are probably valid, I've chosen the one that starts with `/usr/arm-linux-gnueabihf` because it means that we have to change fewer lines in the Dockerfile. I've tested to ensure that `$PREBUILD_STRIP_BIN --version` correctly runs the binary and returns basic version information, which suggests that this should Actually Work, For Real This Time.
christianbundy
requested review from
ralphtheninja and
vweevers
as code owners
vweevers
approved these changes
Feb 18, 2020
|
Thanks for the quick merge! |
|
👍 I have to hit the hay. You can send a PR to leveldown in the mean time if you want, I'll then try to get a release out the door tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The strip binary wasn't found when we looked in the expected
location:
/usr/arm-linux-gnueabihf/bin/arm-linux-gnueabihf-strip. It'sunclear why this is happening, but we need to change the environment
variable
PREBUILD_STRIP_BINso that it points at a valid binary.Solution: We found three binaries that seem to look like
strip:The first two are the exact same binary, confirmed with
sha256sum, andsince their version string contains "crosstool" I'm guessing that
they're the right binary. Since both are probably valid, I've chosen the
one that starts with
/usr/arm-linux-gnueabihfbecause it means that wehave to change fewer lines in the Dockerfile.
I've tested to ensure that
$PREBUILD_STRIP_BIN --versioncorrectlyruns the binary and returns basic version information, which suggests
that this should Actually Work, For Real This Time.