Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Exco bidder documentation #5652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Exco bidder documentation #5652

wants to merge 1 commit into from

Conversation

saar120
Copy link
Contributor

@saar120 saar120 commented Oct 10, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

❌ Deploy Preview for prebid-docs-preview failed. Why did it fail? →

Name Link
🔨 Latest commit f8c1ee3
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6707f34699dcdc00084584ce

@saar120 saar120 mentioned this pull request Oct 10, 2024
Merged
10 tasks
bretg
bretg requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the build failure is related to this PR. Please make the requested updates and the next run should succeed.

dev-docs/bidders/exco.md
biddercode: exco
filename: excoBidAdapter
userIds: britepoolId, criteo, id5Id, identityLink, liveIntentId, netId, parrableId, pubCommonId, unifiedId
tcfeu_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't claim tcfeu_support without also declaring your gvl_id. See https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter

dev-docs/bidders/exco.md

## Example

```javascript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the space in front here

muuki88
muuki88 requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saar120 can you make the requested changes? You prebid adapter has been merged and now the documentation is eligible to merged as well.

dev-docs/bidders/exco.md
biddercode: exco
filename: excoBidAdapter
userIds: britepoolId, criteo, id5Id, identityLink, liveIntentId, netId, parrableId, pubCommonId, unifiedId
tcfeu_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tcfeu_supported: true
tcfeu_supported: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 requested changes

@bretg bretg bretg requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saar120 @muuki88 @bretg