Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a typo in 1st party storage name #5514

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fixing a typo in 1st party storage name #5514

merged 2 commits into from
Oct 11, 2024

Conversation

pm-harshad-mane
Copy link
Contributor

🏷 Type of documentation

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

@netlify Netlify
Copy link

netlify bot commented Jul 23, 2024 •
edited
Loading

✅ Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit a92790c
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6709581eec07160007b5f38f
😎 Deploy Preview https://deploy-preview-5514--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ChrisHuie ChrisHuie self-assigned this Jul 24, 2024
muuki88
muuki88 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haiya

Thanks for fixing 🙏

@muuki88
Copy link
Contributor

muuki88 commented Jul 25, 2024

@pm-harshad-mane can you resolve the conflict? Probably your fork was a little bit out of date :D

@muuki88 muuki88 added the LGTM label Jul 25, 2024
@bretg bretg merged commit 9dc937d into master Oct 11, 2024
5 checks passed
@bretg bretg deleted the pm-harshad-mane-patch-2 branch October 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

@ChrisHuie ChrisHuie ChrisHuie approved these changes

Assignees

@ChrisHuie ChrisHuie

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pm-harshad-mane @muuki88 @ChrisHuie @bretg