Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update theAdx.md #5388

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Update theAdx.md #5388

merged 3 commits into from
Oct 11, 2024

Conversation

mustafakemal16
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 993bf8c
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66e35967933fee00085f102d
😎 Deploy Preview https://deploy-preview-5388--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

description: Prebid TheAdx Bidder Adapter
pbs: true
pbs_app_supported: true
pbjs: true
biddercode: theadx
biddercode: theAdx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
biddercode: theAdx
biddercode: theadx

The bidder code must match the one provided in the bid adapter

https://github.com/prebid/Prebid.js/blob/69d79062781c38d8fafcac189f807e99c4b28f65/modules/theAdxBidAdapter.js#L21

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustafakemal16 can you please update the PR accordingly 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @muuki88 , when selecting a bidder from the Prebid download page, if the bidder class name and bidder code don't match, the download cannot be completed. For example, trying to download the theadx bidder from https://docs.prebid.org/download.html results in an error. Therefore, the prefix in theAdxBidAdapter.js must match the bidder code. If you want to download theAdxBidAdapter, the bidder code should be 'theAdx'. Please correct me if I'm wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that the biddercode is lowercase theadx while the filename is mixed case theAdx. Not ideal, but not the first time this has happened. I'll fix this with the filename header.

@bretg bretg merged commit 59e1727 into prebid:master Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants