-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theAdx.md #5388
Update theAdx.md #5388
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dev-docs/bidders/theAdx.md
Outdated
description: Prebid TheAdx Bidder Adapter | ||
pbs: true | ||
pbs_app_supported: true | ||
pbjs: true | ||
biddercode: theadx | ||
biddercode: theAdx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
biddercode: theAdx | |
biddercode: theadx |
The bidder code must match the one provided in the bid adapter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mustafakemal16 can you please update the PR accordingly 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @muuki88 , when selecting a bidder from the Prebid download page, if the bidder class name and bidder code don't match, the download cannot be completed. For example, trying to download the theadx bidder from https://docs.prebid.org/download.html results in an error. Therefore, the prefix in theAdxBidAdapter.js must match the bidder code. If you want to download theAdxBidAdapter, the bidder code should be 'theAdx'. Please correct me if I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem here is that the biddercode is lowercase theadx
while the filename is mixed case theAdx
. Not ideal, but not the first time this has happened. I'll fix this with the filename header.
🏷 Type of documentation
📋 Checklist