Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loyal Bid Adapter: initial release #5223

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Conversation

teqblaze
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 6dce40c
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6602924e67296c0008724790
😎 Deploy Preview https://deploy-preview-5223--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new adapter.

First problem with this doc is that you can't claim tcfeu_support without also declaring the gvl_id.

Second, please note that the gpp_supported field has been deprecated. We now require gpp_sids as described at https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter :

If you support the IAB’s GPP consent string, add gpp_sids with a comma separated list of section names, e.g. gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp. Default is None.

Finally, note that there some pieces of metadata missing besides gvl_id, e.g. fpd_supported, dchain_supported, deals_supported, ortb_blocking_supported, privacy_sandbox

muuki88

This comment was marked as duplicate.

@teqblaze teqblaze requested review from muuki88 and bretg March 26, 2024 08:52
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Once the PRs are merged, the docs will be too.

| Name | Scope | Description | Example | Type |
|---------------|----------|--------------|---------------------------------|------------|
| `placementId` | optional | Placement Id | `'0'` | `'string'` |
| `endpointId` | optional | Endpoint Id | `'0'` | `'string'` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should include bidfloor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our adapter does not have the bidfloor parameter. Why do we need to add it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks you have it included in your bid adapter submission PR. If this is not intended, can it be removed?

image
https://github.com/prebid/Prebid.js/pull/11253/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@teqblaze teqblaze requested a review from ncolletti April 9, 2024 08:21
@teqblaze
Copy link
Contributor Author

@bretg @ncolletti @muuki88 The prebid.js Loyal adapter is already in release https://github.com/prebid/Prebid.js/releases/tag/8.44.0. Please merge doc

@muuki88 muuki88 merged commit f74c57e into prebid:master Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants