-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loyal Bid Adapter: initial release #5223
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new adapter.
First problem with this doc is that you can't claim tcfeu_support without also declaring the gvl_id.
Second, please note that the gpp_supported
field has been deprecated. We now require gpp_sids
as described at https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter :
If you support the IAB’s GPP consent string, add gpp_sids with a comma separated list of section names, e.g. gpp_sids: tcfeu, tcfca, usnat, usstate_all, usp. Default is None.
Finally, note that there some pieces of metadata missing besides gvl_id, e.g. fpd_supported, dchain_supported, deals_supported, ortb_blocking_supported, privacy_sandbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Once the PRs are merged, the docs will be too.
| Name | Scope | Description | Example | Type | | ||
|---------------|----------|--------------|---------------------------------|------------| | ||
| `placementId` | optional | Placement Id | `'0'` | `'string'` | | ||
| `endpointId` | optional | Endpoint Id | `'0'` | `'string'` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should include bidfloor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our adapter does not have the bidfloor parameter. Why do we need to add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks you have it included in your bid adapter submission PR. If this is not intended, can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
@bretg @ncolletti @muuki88 The prebid.js Loyal adapter is already in release https://github.com/prebid/Prebid.js/releases/tag/8.44.0. Please merge doc |
🏷 Type of documentation
📋 Checklist