Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Between adapter dev docs #2549

Merged
merged 7 commits into from
Dec 7, 2020
Merged

Updated Between adapter dev docs #2549

merged 7 commits into from
Dec 7, 2020

Conversation

egsk
Copy link
Contributor

@egsk egsk commented Dec 2, 2020

added missed parameters and update their description. see prebid/prebid-server#1587

@mansinahar
Copy link
Contributor

Thanks @egsk for addressing the feedback. LGTM :)

dev-docs/bidders/between.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there's an important problem here -- this file is shared by your prebid.js and prebid server adapters.

Prebid strongly recommends that PBJS and PBS adapters take the same set of parameters, so publishers can easily switch between client and server, but if that's not the case, it needs to be clear to publishers which params are supported and required for which.

I see from https://github.com/prebid/Prebid.js/blob/master/modules/betweenBidAdapter.md that your client adapters supports an 's' param which isn't in this doc.

Since your client- and server-params are so different, you might want to break them into different tables?

@egsk
Copy link
Contributor Author

egsk commented Dec 7, 2020

@bretg
I added another table for prebid.js parameters, but I can't find a page with prebid.js adapters documentation. Can you please provide it?
Overall, bidders are using different set of configuration parameters for server- and client-adapters, but as far I can see nobody split parameters into different tables

@bretg
Copy link
Contributor

bretg commented Dec 7, 2020

You server team stomped on the client team's parameters. I fixed from GitHub history.

@bretg bretg added LGTM and removed needs work labels Dec 7, 2020
@bretg bretg merged commit efd7884 into prebid:master Dec 7, 2020
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Jan 21, 2021
* Updated Between adapter dev docs

* Between adapter dev docs: review fix

* Between adapter dev docs: review fix #2

* Added quotes to string params

* Between adapter dev docs: review fix #3

* fixing PBJS adapter params

copied from original client-side adapter commit prebid@8f623b4#diff-b224ab4090e3b286923b7eb808974fcb155f98dda399b7050270d28c7e6f55e4

Co-authored-by: Egor Skorokhodov <skorokhodov@betweenx.com>
Co-authored-by: bretg <bgorsline@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants