Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaato: Send imp.ext object entirely #3995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Smaato: Send imp.ext object entirely #3995

wants to merge 1 commit into from

Conversation

Enigo
Copy link
Contributor

@Enigo Enigo commented Oct 18, 2024 •
edited
Loading

This PR refactors the way how our adapter sends the imp.ext object to the ad server - now the entire object is sent and not only skadn

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4d58f1f

smaato

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smaato/banner.go:9:		extractAdmBanner		100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/native.go:14:	extractAdmNative		85.7%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:70:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:79:	MakeRequests			100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:99:	MakeBids			85.3%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:163:	makeIndividualRequests		89.5%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:196:	splitImpressionsByMediaType	100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:226:	makePodRequests			84.6%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:250:	makeRequest			85.7%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:269:	getAdMarkupType			100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:279:	getTTLFromHeaderOrDefault	100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:293:	renderAdMarkup			100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:308:	convertAdMarkupTypeToMediaType	80.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:323:	prepareCommonRequest		100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:338:	prepareIndividualRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:348:	preparePodRequest		80.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:360:	setUser				95.2%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:403:	setExt				100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:411:	setSite				100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:431:	setApp				100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:438:	setDOOH				100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:445:	setPublisherId			100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:468:	setImpForAdspace		80.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:487:	setImpForAdBreak		89.5%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:521:	removeBidderNodeFromImpExt	84.6%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:543:	groupImpressionsByPod		100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:563:	buildBidVideo			87.5%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:583:	extractBidExt			100.0%
total:									(statements)			92.3%

@Enigo Enigo changed the title PREB-42 Add GPID support Smaato: Add GPID support Oct 18, 2024
@Enigo Enigo changed the title Smaato: Add GPID support Smaato: Send imp.ext object entirely Oct 18, 2024
@Enigo Enigo force-pushed the feature/PREB-42_O_add_gpid_support branch from 4d58f1f to ae02b61 Compare October 18, 2024 14:28
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ae02b61

smaato

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/smaato/banner.go:9:		extractAdmBanner		100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/native.go:14:	extractAdmNative		85.7%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:70:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:79:	MakeRequests			100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:99:	MakeBids			85.3%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:163:	makeIndividualRequests		89.5%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:196:	splitImpressionsByMediaType	100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:226:	makePodRequests			84.6%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:250:	makeRequest			85.7%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:269:	getAdMarkupType			100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:279:	getTTLFromHeaderOrDefault	100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:293:	renderAdMarkup			100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:308:	convertAdMarkupTypeToMediaType	80.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:323:	prepareCommonRequest		100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:338:	prepareIndividualRequest	100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:348:	preparePodRequest		80.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:360:	setUser				95.2%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:403:	setExt				100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:411:	setSite				100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:431:	setApp				100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:438:	setDOOH				100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:445:	setPublisherId			100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:468:	setImpForAdspace		80.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:487:	setImpForAdBreak		89.5%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:521:	removeBidderNodeFromImpExt	84.6%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:543:	groupImpressionsByPod		100.0%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:563:	buildBidVideo			87.5%
github.com/prebid/prebid-server/v2/adapters/smaato/smaato.go:583:	extractBidExt			100.0%
total:									(statements)			92.3%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Enigo