Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InMobi: mtype support #3921

Merged
merged 4 commits into from
Sep 25, 2024
Merged

InMobi: mtype support #3921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73b2411
InMobi adapter changes to support mtype
bkaneyama Sep 14, 2024
7c2044a
removing legacy logic
bkaneyama Sep 16, 2024
03c700e
returning an error if the mtype is missing or invalid
bkaneyama Sep 19, 2024
b8b21d0
removing adapter support for audio mtype responses
bkaneyama Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions adapters/inmobi/inmobi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ func (a *InMobiAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalR

for _, sb := range serverBidResponse.SeatBid {
for i := range sb.Bid {
mediaType := getMediaTypeForImp(sb.Bid[i].ImpID, internalRequest.Imp)
mediaType, err := getMediaTypeForImp(sb.Bid[i])
if err != nil {
return nil, []error{err}
}
bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{
Bid: &sb.Bid[i],
BidType: mediaType,
Expand Down Expand Up @@ -118,18 +121,17 @@ func preprocess(imp *openrtb2.Imp) error {
return nil
}

func getMediaTypeForImp(impId string, imps []openrtb2.Imp) openrtb_ext.BidType {
mediaType := openrtb_ext.BidTypeBanner
for _, imp := range imps {
if imp.ID == impId {
if imp.Video != nil {
mediaType = openrtb_ext.BidTypeVideo
}
if imp.Native != nil {
mediaType = openrtb_ext.BidTypeNative
}
break
func getMediaTypeForImp(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
switch bid.MType {
case openrtb2.MarkupBanner:
return openrtb_ext.BidTypeBanner, nil
case openrtb2.MarkupVideo:
return openrtb_ext.BidTypeVideo, nil
case openrtb2.MarkupNative:
return openrtb_ext.BidTypeNative, nil
default:
return "", &errortypes.BadServerResponse{
Message: fmt.Sprintf("Unsupported mtype %d for bid %s", bid.MType, bid.ID),
}
}
return mediaType
}
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-app-banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
"price": 2.0,
"id": "1234",
"adm": "bannerhtml",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 1
}
]
}
Expand All @@ -94,6 +95,7 @@
"adm": "bannerhtml",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 1,
"ext": {
"prebid": {
"meta": {
Expand Down
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-app-native.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
"price": 2.0,
"id": "1234",
"adm": "native-json",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 4
}
]
}
Expand All @@ -92,6 +93,7 @@
"adm": "native-json",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 4,
"ext": {
"prebid": {
"meta": {
Expand Down
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-app-video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@
"price": 2.0,
"id": "1234",
"adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 2
}
]
}
Expand All @@ -96,6 +97,7 @@
"adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 2,
"ext": {
"prebid": {
"meta": {
Expand Down
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-web-banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@
"price": 2.0,
"id": "1234",
"adm": "bannerhtml",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 1
}
]
}
Expand All @@ -92,6 +93,7 @@
"adm": "bannerhtml",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 1,
"ext": {
"prebid": {
"meta": {
Expand Down
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-web-native.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@
"price": 2.0,
"id": "1234",
"adm": "native-json",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 4
}
]
}
Expand All @@ -90,6 +91,7 @@
"adm": "native-json",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 4,
"ext": {
"prebid": {
"meta": {
Expand Down
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/exemplary/simple-web-video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
"price": 2.0,
"id": "1234",
"adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 2
}
]
}
Expand All @@ -94,6 +95,7 @@
"adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 2,
"ext": {
"prebid": {
"meta": {
Expand Down
4 changes: 3 additions & 1 deletion adapters/inmobi/inmobitest/supplemental/banner-format-coersion.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@
"price": 2.0,
"id": "1234",
"adm": "bannerhtml",
"impid": "imp-id"
"impid": "imp-id",
"mtype": 1
}
]
}
Expand All @@ -100,6 +101,7 @@
"adm": "bannerhtml",
"crid": "123456789",
"nurl": "https://some.event.url/params",
"mtype": 1,
"ext": {
"prebid": {
"meta": {
Expand Down
97 changes: 97 additions & 0 deletions adapters/inmobi/inmobitest/supplemental/invalid-mtype.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
{
"mockBidRequest": {
"site": {
"page": "https://www.inmobi.com"
},
"id": "req-id",
"device": {
"ip": "1.1.1.1",
"ua": "Mozilla/5.0 (Linux; Android 8.0.0; SM-G960F Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.84 Mobile Safari/537.36"
},
"imp": [
{
"ext": {
"bidder": {
"plc": "1621323101291"
}
},
"video": {
"w": 640,
"h": 360,
"mimes": ["video/mp4"]
},
"id": "imp-id"
}
]
},
"httpCalls": [{
"expectedRequest": {
"uri": "https://api.w.inmobi.com/showad/openrtb/bidder/prebid",
"body": {
"site": {
"page": "https://www.inmobi.com"
},
"id": "req-id",
"device": {
"ip": "1.1.1.1",
"ua": "Mozilla/5.0 (Linux; Android 8.0.0; SM-G960F Build/R16NW) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.84 Mobile Safari/537.36"
},
"imp": [
{
"ext": {
"bidder": {
"plc": "1621323101291"
}
},
"video": {
"w": 640,
"h": 360,
"mimes": ["video/mp4"]
},
"id": "imp-id"
}
]
},
"impIDs":["imp-id"]
},
"mockResponse": {
"status": 200,
"body": {
"id": "req-id",
"seatbid": [
{
"bid": [
{
"ext": {
"prebid": {
"meta": {
"networkName": "inmobi"
}
}
},
"nurl": "https://some.event.url/params",
"crid": "123456789",
"adomain": [],
"price": 2.0,
"id": "1234",
"adm": "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <VAST version=\"3.0\"></VAST>",
"impid": "imp-id",
"mtype": 0
}
]
}
]
}
}
}],

"expectedBidResponses":[],
"expectedMakeBidsErrors":[
{
"value":"Unsupported mtype 0 for bid 1234",
"comparison":"literal"
}
]
}


Loading