Fix: Set bid meta adaptercode to adapter name #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexBVolcy
reviewed
May 6, 2024
| @@ -0,0 +1,64 @@ | |||
| { | |||
| "description": "Imp extension references valid bidder alias of appnexus defined in the request ext.prebid.aliases field.", | |||
| "config": { | |||
There was a problem hiding this comment.
is this config supposed to be empty, or can it be deleted?
AlexBVolcy
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses most of #3363. With this fix,
seatbid[].bid[].ext.prebid.meta.adaptercodewill be set to the adapter name in the request alias and alternate bidder code use cases.In the hard alias case, the adaptercode is still set to the hard alias. This is a larger change that will be addressed in its own PR.
In this PR I also removed all references to
adaptercodein the exchange JSON tests since they no longer serve a purpose as the exchange tests mock objects that contain theadaptercodelogic. As such, I made some updates to the auction endpoint tests that allow us to verify the request alias, hard alias and alternate bidder code logic work correctly with respect to theadaptercode.