New Adapter:bluesea #2816
Merged
New Adapter:bluesea #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueseasx
force-pushed
the
new-adapater-bluesea
branch
from
8ceab4a to
fff00e0
Compare
|
@blueseasx Your fork repo is not in sync with master which is why the validation checks are failing. Please sync your fork with master to pass the validation check |
|
@blueseasx Pr checks are failing. Requesting you to please check once. |
blueseasx
force-pushed
the
new-adapater-bluesea
branch
from
b6313d0 to
1e65993
Compare
added 2 commits
June 6, 2023 08:08
…unc to retrieve BidType from response, add some tests
|
@blueseasx overall looks good their are couple of open comments. Please address them so that we can merge PR |
add params_test add length check of requestData in makerequests method
onkarvhanumante
approved these changes
Jun 9, 2023
Sonali-More-Xandr
approved these changes
Jun 12, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.