OpenRTB 2.6 For Internal Model #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
commented
Jul 5, 2022
| @@ -16,7 +16,8 @@ require ( | |||
| github.com/julienschmidt/httprouter v1.3.0 | |||
| github.com/lib/pq v1.10.4 | |||
| github.com/mitchellh/copystructure v1.2.0 | |||
| github.com/mxmCherry/openrtb/v15 v15.0.1 | |||
| github.com/mxmCherry/openrtb v13.0.0+incompatible | |||
| github.com/mxmCherry/openrtb/v16 v16.0.0-alpha.2 | |||
There was a problem hiding this comment.
Don't worry about the alpha status. The library is being kept in alpha until it's implemented Prebid Server to prove it works well.
| } | ||
|
|
||
| // ExtRequestPrebidSChainSChain defines the contract for bidrequest.ext.prebid.schains[i].schain | ||
| type ExtRequestPrebidSChainSChain struct { |
There was a problem hiding this comment.
Goodbye SChainSchain!
bsardo
reviewed
Jul 7, 2022
bsardo
approved these changes
Jul 8, 2022
This was referenced Jul 11, 2022
Merged
wwwyyy
pushed a commit
to wwwyyy/prebid-server
that referenced
this pull request
Jul 19, 2022
* 'master' of https://github.com/wwwyyy/prebid-server: AMP targeting query string (prebid#2293) Fix typo (prebid#2275) Sovrn: Update endpoint (prebid#2305) Added native support (prebid#2299) Bidders Should Be Listed Alphabetically (prebid#2295) Kargo Adapter: Add userSync to bidder-info (prebid#2294) OpenRTB 2.6 For Internal Model (prebid#2280)
pm-aadit-patil
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Sep 22, 2022
* OpenRTB 2.6 Initial Commit * Fix Compilation Issues - Move To v16alpha2 * Replace ExtUserEid With MXMCherry Type * Use SChain Model From MXMCherry * Review Pass
pm-aadit-patil
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Sep 22, 2022
* OpenRTB 2.6 Initial Commit * Fix Compilation Issues - Move To v16alpha2 * Replace ExtUserEid With MXMCherry Type * Use SChain Model From MXMCherry * Review Pass
pm-aadit-patil
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Sep 22, 2022
* OpenRTB 2.6 Initial Commit * Fix Compilation Issues - Move To v16alpha2 * Replace ExtUserEid With MXMCherry Type * Use SChain Model From MXMCherry * Review Pass
jorgeluisrocha
pushed a commit
to jwplayer/prebid-server
that referenced
this pull request
Sep 28, 2022
* OpenRTB 2.6 Initial Commit * Fix Compilation Issues - Move To v16alpha2 * Replace ExtUserEid With MXMCherry Type * Use SChain Model From MXMCherry * Review Pass
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
* OpenRTB 2.6 Initial Commit * Fix Compilation Issues - Move To v16alpha2 * Replace ExtUserEid With MXMCherry Type * Use SChain Model From MXMCherry * Review Pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the internal OpenRTB model to support 2.6. This will allow the core code and adapters to access OpenRTB 2.6 fields, but features (like schains, eids, gdpr, ccpa) will still be supported at 2.5 locations only until a future PR adds up convert and down convert support.
This PR changes adapter code. The changes are just simple type replacements except for the Rubicon adapter which relied upon EID.ID, an non-standard field. Removed with their approval and flagging them here (@bretg) to review the changes to their tests.