New Adapter: yahoossp (Rebrand yssp to yahoossp keeping the yssp alias)

[oath-jac]

We were told by legal that we'll go further with yahoossp name. The verizonmedia adapter will be removed at later stage.

[VeronikaSolovei9]

LGTM

[guscarreon]

Looks good but before approving I was wondering if we still need files openrtb_ext/imp_yssp.go, static/bidder-params/yssp.json and static/bidder-info/yssp.yaml? We seem to no longer be using the ExtImpYSSP struct inside adapters/yahoossp/yahoossp.go and ExtImpYahooSSP seems to be a identical to ExtImpYSSP except for the name.

1 package openrtb_ext
2
3 // ExtImpYSSP defines the contract for bidrequest.imp[i].ext.yssp
4 type ExtImpYSSP struct {
5     Dcn string `json:"dcn"`
6     Pos string `json:"pos"`
7 }
openrtb_ext/imp_yssp.go

static/bidder-info/yssp.yaml and static/bidder-info/yahoossp.yaml seem to be identical files too.

[oath-jac]

We wanted to keep the yssp alias for the yahoossp adapter, that means we declared the bidder using the same builder.
We can not remove the static/bidder-info/yssp.yaml as it is needed.
In go server I understood that for aliases you reuse the same bidder builder but you have to duplicate some files like the static ones. In the java server we just declare the alias in the server config aliases property.

Looks good but before approving I was wondering if we still need files openrtb_ext/imp_yssp.go, static/bidder-params/yssp.json and static/bidder-info/yssp.yaml? We seem to no longer be using the ExtImpYSSP struct inside adapters/yahoossp/yahoossp.go and ExtImpYahooSSP seems to be a identical to ExtImpYSSP except for the name.

1 package openrtb_ext
2
3 // ExtImpYSSP defines the contract for bidrequest.imp[i].ext.yssp
4 type ExtImpYSSP struct {
5     Dcn string `json:"dcn"`
6     Pos string `json:"pos"`
7 }
openrtb_ext/imp_yssp.go

static/bidder-info/yssp.yaml and static/bidder-info/yahoossp.yaml seem to be identical files too.

We wanted to keep the yssp alias for the yahoossp adapter, that means we declared the bidder using the same builder.
We can not remove the static/bidder-info/yssp.yaml as it is needed.
In go server I understood that for aliases you reuse the same bidder builder but you have to duplicate some files like the static ones. In the java server we just declare the alias in the server config aliases property.

[SyntaxNode]

Looks good to me. Please remove the ExtImpYSSP as the intent is for the ExtImpXXX structs to correlate to an adapter implementation, and now you have - rightfully so - ExtImpYahooSSP.

[SyntaxNode]

In the java server we just declare the alias in the server config aliases property.

The alias functionality in PBS-Go is still in its infancy. We'll continue to make improvements in the near future. Don't expect to see the exact same approach from PBS-Java, we have other ideas in mind. The end goal is similar though in that no code is required for aliases.

[SyntaxNode]

Please also remove the /params/race/banner.json file. That race detection pattern has been removed and replaced with enhanced memory sharing checks in the json test framework.

[guscarreon]

LGTM

[SyntaxNode]

@oath-jac This is looking good. Please open a docs PR for the new yahoossp bidder, just as you did for yssp previously. We will not merge this PR until the docs PR is opened.

[VeronikaSolovei9]

LGTM

[SyntaxNode]

Docs PR: prebid/prebid.github.io#3283