Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old race condition tests #1958

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

guscarreon
Copy link
Contributor

Pull request #1756 added a new test in adapters/adapterstest/test_json.go to assert no data races happen when calling the MakeRequests() implementation of every bidder adapter in this repository. This pull request removes the old data race detection functionality found in prebid-server core as well as the supporting JSON files located inside every adapter's adapters/fooadapter/adftest/params/race directory.

@mansinahar mansinahar changed the title Remove old race conidtion tests Remove old race condition tests Aug 12, 2021
@SyntaxNode
Copy link
Contributor

@guscarreon Please open a docs PR to update the new bidder guide before merging this in.

Copy link
Contributor

@AlexBVolcy AlexBVolcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@guscarreon
Copy link
Contributor Author

Documentaion PR:
prebid/prebid.github.io#3216

@mansinahar mansinahar merged commit 4a0e365 into prebid:master Aug 19, 2021
wwwyyy pushed a commit to wwwyyy/prebid-server that referenced this pull request Aug 20, 2021
… prebid-master

* 'master' of https://github.com/prebid/prebid-server:
  Update Viper (prebid#1969)
  /cookie_sync Endpoint Rewrite (prebid#1879)
  New Adapter: IQZone (prebid#1964)
  Remove old race conidtion tests (prebid#1958)
  Remove time.Now() as the first parameter of NewRates() (prebid#1953)

# Conflicts:
#	config/config.go
#	usersync/usersyncers/syncer_test.go
jizeyopera pushed a commit to operaads/prebid-server that referenced this pull request Oct 13, 2021
shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants