Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid unexpected EOF on gz writer #1449

Merged
merged 3 commits into from
Aug 28, 2020
Merged

fix: avoid unexpected EOF on gz writer #1449

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a414ef9
fix: avoid unexpected EOF on gz writer
gpolaert Aug 21, 2020
983fedc
fix: reset when errors occur
gpolaert Aug 27, 2020
0e4a897
add a test to fix the expected output format
gpolaert Aug 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions analytics/pubstack/eventchannel/eventchannel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,13 @@ func (c *EventChannel) flush() {
return
}

// reset buffers and writers
defer c.reset()

// finish writing gzip header
err := c.gz.Flush()
err := c.gz.Close()
SyntaxNode marked this conversation as resolved.
Show resolved Hide resolved
if err != nil {
glog.Warning("[pubstack] fail to flush gzipped buffer")
glog.Warning("[pubstack] fail to close gzipped buffer")
return
}

Expand All @@ -108,9 +111,6 @@ func (c *EventChannel) flush() {
return
}

// reset buffers and writers
c.reset()

// send events (async)
go c.send(payload)
}
Expand Down