Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook handler called without appropriate recovery mechanism #3737

Open
linux019 opened this issue Jun 7, 2024 · 0 comments
Open

Hook handler called without appropriate recovery mechanism #3737

linux019 opened this issue Jun 7, 2024 · 0 comments
Assignees
@bsardo
Labels
PBS-Go

Comments

@linux019
Copy link
Contributor

linux019 commented Jun 7, 2024 •
edited
Loading

Here code spawns a goroutine to call module hook handler but missing defer with recover()

prebid-server/hooks/hookexecution/execution.go

Line 105 in 7702a78

go func() {

That would to process crash
@bsardo bsardo added the PBS-Go label Jun 10, 2024
linux019 pushed a commit to linux019/prebid-server that referenced this issue Oct 30, 2024
prebid#3737 catch panic in executeHook
51a2a2f
@linux019 linux019 mentioned this issue Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsardo bsardo

Labels
PBS-Go
Projects
Prebid Server Prioritization
Status: Research
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsardo @linux019