Appnexus: Update appendMemberId function (#2747)

adapters/appnexus/appnexus.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"net/http"
+	"net/url"
 	"strconv"
 	"strings"
 
@@ -27,15 +28,20 @@ const (
 )
 
 type adapter struct {
-	uri             string
+	uri             url.URL
 	hbSource        int
 	randomGenerator randomutil.RandomGenerator
 }
 
 // Builder builds a new instance of the AppNexus adapter for the given bidder with the given config.
 func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
+	uri, err := url.Parse(config.Endpoint)
+	if err != nil {
+		return nil, err
+	}
+
 	bidder := &adapter{
-		uri:             config.Endpoint,
+		uri:             *uri,
 		hbSource:        resolvePlatformID(config.PlatformID),
 		randomGenerator: randomutil.RandomNumberGenerator{},
 	}
@@ -146,11 +152,11 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E
 	// If impressions number per pod is more than maxImpsPerReq - divide those imps to several requests but keep pod id the same
 	// If  adpodId feature disabled and impressions number per pod is more than maxImpsPerReq  - divide those imps to several requests but do not include ad pod id
 	if isVIDEO == 1 && *shouldGenerateAdPodId {
-		requests, errors := a.buildAdPodRequests(request.Imp, request, reqExt, requestURI)
+		requests, errors := a.buildAdPodRequests(request.Imp, request, reqExt, requestURI.String())
 		return requests, append(errs, errors...)
 	}
 
-	requests, errors := splitRequests(request.Imp, request, reqExt, requestURI)
+	requests, errors := splitRequests(request.Imp, request, reqExt, requestURI.String())
 	return requests, append(errs, errors...)
 }
 
@@ -375,12 +381,11 @@ func (a *adapter) findIabCategoryForBid(bid *appnexusBidExt) (string, bool) {
 	return iabCategory, ok
 }
 
-func appendMemberId(uri string, memberId string) string {
-	if strings.Contains(uri, "?") {
-		return uri + "&member_id=" + memberId
-	}
-
-	return uri + "?member_id=" + memberId
+func appendMemberId(uri url.URL, memberId string) url.URL {
+	q := uri.Query()
+	q.Set("member_id", memberId)
+	uri.RawQuery = q.Encode()
+	return uri
 }
 
 func buildDisplayManageVer(req *openrtb2.BidRequest) string {

adapters/appnexus/appnexus_test.go

@@ -1,6 +1,7 @@
 package appnexus
 
 import (
+	"net/url"
 	"testing"
 
 	"github.com/prebid/prebid-server/adapters/adapterstest"
@@ -23,12 +24,12 @@ func TestJsonSamples(t *testing.T) {
 	adapterstest.RunJSONBidderTest(t, "appnexustest", bidder)
 }
 
-func TestMemberQueryParam(t *testing.T) {
-	uriWithMember := appendMemberId("http://ib.adnxs.com/openrtb2?query_param=true", "102")
-	expected := "http://ib.adnxs.com/openrtb2?query_param=true&member_id=102"
-	if uriWithMember != expected {
-		t.Errorf("appendMemberId() failed on URI with query string. Expected %s, got %s", expected, uriWithMember)
-	}
+func TestAppendMemberID(t *testing.T) {
+	uri, err := url.Parse("http://ib.adnxs.com/openrtb2?query_param=true")
+	assert.NoError(t, err, "Failed to parse URI with query string")
+	uriWithMember := appendMemberId(*uri, "102")
+	expected := "http://ib.adnxs.com/openrtb2?member_id=102&query_param=true"
+	assert.Equal(t, expected, uriWithMember.String(), "Failed to append member id to URI with query string")
 }
 
 func TestBuilderWithPlatformID(t *testing.T) {