adding tests for advertiser insted of pubrender.

prebid · Sep 16, 2024 · 38120a5 · 38120a5
1 parent 4d7e45d
commit 38120a5
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 156 deletions.
diff --git a/adapters/adnuntius/adnuntius.go b/adapters/adnuntius/adnuntius.go
@@ -61,7 +61,7 @@ type Ad struct {
 	LineItemId      string
 	Html            string
 	DestinationUrls map[string]string
-	Advertiser      adnAdvertiser
+	Advertiser      adnAdvertiser `json:"advertiser,omitempty"`
 }
 
 type AdUnit struct {
@@ -387,7 +387,7 @@ func generateReturnExt(ad Ad, request *openrtb2.BidRequest) (json.RawMessage, er
 		}
 	}
 
-	if requestRegsExt != nil && requestRegsExt.DSA != nil {
+	if ad.Advertiser.Name != "" && requestRegsExt != nil && requestRegsExt.DSA != nil {
 		legalName := ad.Advertiser.Name
 		if ad.Advertiser.LegalName != "" {
 			legalName = ad.Advertiser.LegalName
@@ -405,10 +405,8 @@ func generateReturnExt(ad Ad, request *openrtb2.BidRequest) (json.RawMessage, er
 		}
 
 		return returnExt, nil
-	} else {
-		return nil, nil
 	}
-
+	return nil, nil
 }
 
 func generateAdResponse(ad Ad, imp openrtb2.Imp, html string, request *openrtb2.BidRequest) (*openrtb2.Bid, []error) {

diff --git a/...supplemental/check-dsa-pubrender-nil.json → .../check-dsa-advertiser-legalName copy.json b/...supplemental/check-dsa-pubrender-nil.json → .../check-dsa-advertiser-legalName copy.json
@@ -88,8 +88,8 @@
 									"creativeId": "jn9hpzvlsf8cpdmm",
 									"lineItemId": "q7y9qm5b0xt9htrv",
 									"advertiser": {
-										"legalName": "LegalName",
-										"name": "Name"
+										"name": "Name",
+										"legalName": "LegalName"
 									}
 								}
 							]

diff --git a/...lemental/check-dsa-legalName-omitted.json → ...eck-dsa-advertiser-legalName-omitted.json b/...lemental/check-dsa-legalName-omitted.json → ...eck-dsa-advertiser-legalName-omitted.json
diff --git a/...emental/check-dsa-pubrender-non-zero.json → ...emental/check-dsa-advertiser-omitted.json b/...emental/check-dsa-pubrender-non-zero.json → ...emental/check-dsa-advertiser-omitted.json
@@ -15,7 +15,6 @@
 			"ext": {
 				"dsa": {
 					"dsarequired": 3,
-					"pubrender": 1,
 					"datatopub": 1
 				}
 			}
@@ -87,11 +86,7 @@
 									"creativeWidth": "980",
 									"creativeHeight": "240",
 									"creativeId": "jn9hpzvlsf8cpdmm",
-									"lineItemId": "q7y9qm5b0xt9htrv",
-									"advertiser": {
-										"legalName": "LegalName",
-										"name": "Name"
-									}
+									"lineItemId": "q7y9qm5b0xt9htrv"
 								}
 							]
 						}
@@ -116,14 +111,7 @@
 						"cid": "q7y9qm5b0xt9htrv",
 						"crid": "jn9hpzvlsf8cpdmm",
 						"w": 980,
-						"h": 240,
-						"ext": {
-							"dsa": {
-								"paid": "LegalName",
-								"behalf": "LegalName",
-								"adrender": 0
-							}
-						}
+						"h": 240
 					},
 					"type": "banner"
 

diff --git a/adapters/adnuntius/adnuntiustest/supplemental/check-dsa-pubrender-zero.json b/adapters/adnuntius/adnuntiustest/supplemental/check-dsa-pubrender-zero.json