Lunamedia: Pass site.domain field
#2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marki1an you fixed unit test. But what about integration test? |
|
Is this what the Go adapter does? https://github.com/prebid/prebid-server/blob/3789cf91b8e9906d8716000b68817d51971d1559/adapters/lunamedia/lunamedia.go#L164 |
|
@bretg yep, the Go adapter is replacing the domain with an empty string. |
|
But the point of the ticket is that they want to receive the domain, not have it nulled out. (?) |
Yes... So this means that Go adapter should also get this change. |
Net-burst
changed the title
domain fielddomain field
Net-burst
changed the title
domain fieldsite.domain field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.