Add Unicorn bidder #1201
Merged
Add Unicorn bidder #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanchyk
suggested changes
Apr 26, 2021
| modifiedImps = modifyImps(request.getImp()); | ||
| source = updateSource(request.getSource()); | ||
| firstImpAccountId = parseImpExtBidder(requestImps.get(0)).getAccountId(); | ||
|
|
| final Integer firstImpAccountId; | ||
| try { | ||
| validateRegs(request.getRegs()); | ||
| final List<Imp> requestImps = request.getImp(); |
There was a problem hiding this comment.
Pls move upper before try...catch.
| try { | ||
| validateRegs(request.getRegs()); | ||
| final List<Imp> requestImps = request.getImp(); | ||
| modifiedImps = modifyImps(request.getImp()); |
There was a problem hiding this comment.
Pls use requestImps instead.
| return Result.withValue(createRequest(request, modifiedImps, source, modifiedExtRequest)); | ||
| } | ||
|
|
||
| private ExtRequest modifyExtRequest(ExtRequest extRequest, Integer accountId) { |
There was a problem hiding this comment.
Pls rearrange methods in call order.
| .bidder(extImpBidder.toBuilder().placementId(resolvedPlacementId).build()) | ||
| .build(); | ||
| impBuilder | ||
| .tagid(getStoredRequestImpId(imp)) |
There was a problem hiding this comment.
Use resolvedPlacementId instead.
rpanchyk
approved these changes
Apr 27, 2021
nickluck8
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck8
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck8
pushed a commit
that referenced
this pull request
Aug 10, 2021
SerhiiNahornyi
pushed a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from prebid/prebid-server#1719