Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unicorn bidder #1201

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Add Unicorn bidder #1201

merged 3 commits into from
Apr 27, 2021

Conversation

SerhiiNahornyi
Copy link
Collaborator

@SerhiiNahornyi SerhiiNahornyi commented Mar 28, 2021

modifiedImps = modifyImps(request.getImp());
source = updateSource(request.getSource());
firstImpAccountId = parseImpExtBidder(requestImps.get(0)).getAccountId();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty line.

final Integer firstImpAccountId;
try {
validateRegs(request.getRegs());
final List<Imp> requestImps = request.getImp();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls move upper before try...catch.

try {
validateRegs(request.getRegs());
final List<Imp> requestImps = request.getImp();
modifiedImps = modifyImps(request.getImp());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls use requestImps instead.

return Result.withValue(createRequest(request, modifiedImps, source, modifiedExtRequest));
}

private ExtRequest modifyExtRequest(ExtRequest extRequest, Integer accountId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls rearrange methods in call order.

.bidder(extImpBidder.toBuilder().placementId(resolvedPlacementId).build())
.build();
impBuilder
.tagid(getStoredRequestImpId(imp))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use resolvedPlacementId instead.

@rpanchyk rpanchyk merged commit 4247e8b into master Apr 27, 2021
@rpanchyk rpanchyk deleted the unicorn/implementing branch April 27, 2021 10:48
nickluck8 pushed a commit that referenced this pull request Aug 9, 2021
nickluck8 pushed a commit that referenced this pull request Aug 10, 2021
nickluck8 pushed a commit that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants