Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hwv to bid request #1013

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Add hwv to bid request #1013

merged 1 commit into from
Jul 9, 2024

Conversation

OlenaPostindustria
Copy link
Collaborator

Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlenaPostindustria can you please fix the CircleCI build errors? Thanks!

@OlenaPostindustria
Copy link
Collaborator Author

@jsligh Looks like the new GMA SDK version requires a higher version of Xcode so I had to update Circle CI config. But as I updated the version of Xcode, I ran into another problem that I described in this issue - #962. In short, some tests fail specifically on iOS 17+. I'll try to take a look at this this week.

@OlenaPostindustria OlenaPostindustria marked this pull request as draft July 3, 2024 14:21
@OlenaPostindustria OlenaPostindustria marked this pull request as ready for review July 3, 2024 14:58
Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jsligh jsligh merged commit b25d72f into master Jul 9, 2024
4 checks passed
@jsligh jsligh deleted the 1012/sdk-does-not-send-hwv branch July 9, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants