Set SDK Initialization True before Completion Handler Invocation

[jsligh]

Fixes #711

[YuriyVelichkoPI]

There is a change in state management due to the misleading name of the flag.

The tasksCompletedSuccessfully indicates that tasks are just completed. SDK doesn't consider the status of tasks. So we should set

tasksCompletedSuccessfully = true; 

Otherwise, the function isSdkInitialized might return false if the publisher didn't provide a listner.

In any case, I'd suggest to fix the issue not by moving the place of changing value of the flag but calling the listener asynchronously.

[jsligh]

There is a change in state management due to the misleading name of the flag.

The tasksCompletedSuccessfully indicates that tasks are just completed. SDK doesn't consider the status of tasks. So we should set

tasksCompletedSuccessfully = true; 

Otherwise, the function isSdkInitialized might return false if the publisher didn't provide a listner.

In any case, I'd suggest to fix the issue not by moving the place of changing value of the flag but calling the listener asynchronously.

But calling it asynchronously would still not guarantee that isSdkInitialized returns true before the listener fires. It would just create a race condition would it not?

[YuriyVelichkoPI]

It shouldn't if to add the task (call the lister function) to the queue using, for example, Handler(Looper.getMainLooper())

[jsligh]

@YuriyVelichkoPI thank you for your review/help/direction, I have added the initializationListener to the main queue in another runnable so it is queued for execution AFTER tasksCompletedSuccessfully = true. I have tested this use case in the test app and the queue works as expected every time.

[YuriyVelichkoPI]

Oh, I missed the point that postOnMainThread is our internal function. The name mislead me to https://docs.mapbox.com/android/maps/api/10.18.1/mapbox-maps-android/com.mapbox.maps.threading/-animation-thread-controller/post-on-main-thread.html

Which says:

If called from Android Main thread - will be executed immediately in the same callchain otherwise will be posted on Android Main thread explicitly.

But in this case - it is just a wrapper for Handler(Looper.getMainLooper()), so it should work well!

[YuriyVelichkoPI]

LGTM