Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory issue related to spring-boot-actuator + HdrHistogram #1

Closed
jordillachmrf opened this issue May 4, 2018 · 4 comments
Closed
Assignees

Comments

@jordillachmrf
Copy link
Collaborator

We are having a memory usage related issue with prebid-cache-java.

We were able to reproduce the problem and got some snapshots that highlight a lot of memory pressure.

To our understanding the culprit is the combo of spring-boot-actuator and hdrhistogram library (https://hdrhistogram.github.io/HdrHistogram/) which is a transitive dependency of the former

|INFO] +-org.springframework.boot:spring-boot-starter-actuator:jar:2.0.0.RC2:compile
[INFO] | +- org.springframework.boot:spring-boot-actuator-autoconfigure:jar:2.0.0.RC2:compile
[INFO] | | +- org.springframework.boot:spring-boot-actuator:jar:2.0.0.RC2:compile
[INFO] | | - org.springframework:spring-context:jar:5.0.4.RELEASE:compile
[INFO] | | - org.springframework:spring-expression:jar:5.0.4.RELEASE:compile
[INFO] | - io.micrometer:micrometer-core:jar:1.0.0:compile
[INFO] | +- org.hdrhistogram:HdrHistogram:jar:2.1.10:compile

Here are the snapshots, BTW we are using prebid-cache-java with the manage profile active

memory_high

The memory just keeps increasing

memory_increase

@TerentievEvgany
Copy link
Contributor

When you use manage profile it means that you enable actuator, please try to run prebid-cache without this profile.

@jordillachmrf
Copy link
Collaborator Author

Thanks for the response. Yeah, absolutely that is what we are going to try.

In fact I think that we could have some kind of cardinality problem as suggested in some comments in spring-projects/spring-boot#11338 . But as we do not really need actuator, we will stop using it as you suggested

But do you think it could be feasible to update some project dependencies ?

Spring Boot RC2 is still being used while 2.0.1 was released a while ago https://spring.io/blog/2018/04/05/spring-boot-2-0-1-available-now
In 2.0.1 there are, not related to this issue, lots of bugfixes and improvements done in actuator, micrometerio, spring-core, ...
Also please consider updating project-reactor which has been intesively bug fixed and improved lately https://github.com/reactor/reactor-core/releases

@TerentievEvgany
Copy link
Contributor

Sure, I agree with You, I'll update all dependencies soon.

@TerentievEvgany
Copy link
Contributor

Hi Jordi, all dependencies was updated.

TerentievEvgany pushed a commit that referenced this issue Jun 18, 2018
…aerospike

Hb 2599 replacing redis with aerospike
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants