Eskimi Bid Adapter: Added support for video

[myDisconnect]

Type of change

• Bugfix

• Feature

• New bidder adapter

• Code style update (formatting, local variables)

• Refactoring (no functional changes, no api changes)

• Build related changes

• CI related changes

• Does this change affect user-facing APIs or examples documented on http://prebid.org?

• Other

Description of change

Added support to instream video to Eskimi Adapter

Other information

[myDisconnect]

Hello @osazos,
Please review our Pull Request.

Best Regards,
Andrius

[osazos]

Hi @myDisconnect, sry for delay, this will be done today or tomorrow

[osazos]

Hi @myDisconnect

Basically it is ok for me regarding your code.

But when I tested your adapter, I was not able to set the optional params you added in your doc like bcat, I can add it through mediaTypes.ortb2Imp by the way. Is it what you expect? If yes, you should be more explicit in your doc (also, your example for bcat should be IAB1-1 IMO).

ex:

         // Replace this object to test a new Adapter!
          bids: [{
            bidder: 'eskimi',
            params: {
              placementId: 13144370,
              bcat: ['IAB-1'],
              badv: 'example.com',
            }
          }]

You should update your doc to properly explain what is expected.

[mrobakowski]

@osazos Thank you for noticing this. We did not intend to use ortb2Imp. It was intended to work as it is described in the docs. I fixed that and added the missing test.

BTW the prebid.org docs PR is here prebid/prebid.github.io#4594, I see it's missing from the PR description.

[osazos]

LGTM