Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Bid Adapters: point tmax at request object #9770

Merged
merged 26 commits into from
Apr 11, 2023
Merged

Various Bid Adapters: point tmax at request object #9770

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f654a5b
Removed 'CreateEidsArray' import statements, as well as references to…
Justin-Quinn51 Mar 2, 2023
4ad192b
Revert "Removed 'CreateEidsArray' import statements, as well as refer…
Justin-Quinn51 Mar 9, 2023
602183c
Merge branch 'master' into cross-module-imports
Justin-Quinn51 Mar 9, 2023
4e6bad0
passed all tests
Justin-Quinn51 Mar 14, 2023
6436712
passed tests with bluebillywigAdapter
Justin-Quinn51 Mar 14, 2023
7f38af2
Impactify bid adapter passed tests
Justin-Quinn51 Mar 15, 2023
cc9c5b4
Mediakeys bid adapter passing tests
Justin-Quinn51 Mar 15, 2023
24ad297
Sharethrough bid adapter passed tests
Justin-Quinn51 Mar 15, 2023
7c245af
Connectad bid adapter passed tests
Justin-Quinn51 Mar 15, 2023
7f10c24
Added tests back to expectedEids object, and adjusted userIdAsEids ar…
Justin-Quinn51 Mar 15, 2023
380b7cc
Yieldmo bid adapter passed tests
Justin-Quinn51 Mar 16, 2023
a6a87db
Smartadserver bid adapter passed tests
Justin-Quinn51 Mar 16, 2023
3c27c0e
Removed unnecessary reassignment of bidUserId to eids
Justin-Quinn51 Mar 16, 2023
e425ceb
Removed unnecessary reassignment of bidUserId to eids
Justin-Quinn51 Mar 16, 2023
e42a124
Improveddigital bid adapter passed tests
Justin-Quinn51 Mar 20, 2023
e651a82
Yieldmo bid adapter passed tests
Justin-Quinn51 Mar 20, 2023
557846f
Sovrn bid adapter passed tests
Justin-Quinn51 Mar 20, 2023
05b9fa5
Ttd bid adapter passed tests
Justin-Quinn51 Mar 25, 2023
22ff02c
Refactored adapters to draw tmax values from bidderRequest object and…
Justin-Quinn51 Apr 5, 2023
1797434
Merge branch 'master' into tmax-bug
Justin-Quinn51 Apr 5, 2023
c0f2850
Update nexx360BidAdapter.js
patmmccann Apr 6, 2023
967880c
Deleted unrelated ttsBidAdapter file from PR
Justin-Quinn51 Apr 7, 2023
7367085
Deleted unrelated ttdBidAdapter_spec file from PR
Justin-Quinn51 Apr 7, 2023
e1eb28c
add back ttd adapter
ChrisHuie Apr 10, 2023
273d722
add ttd spec flle back
ChrisHuie Apr 10, 2023
50148aa
add new line
ChrisHuie Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update nexx360BidAdapter.js
  • Loading branch information
@patmmccann
patmmccann authored Apr 6, 2023
commit c0f285099155a964684adf58cd3068ecedd32981
1 change: 0 additions & 1 deletion modules/nexx360BidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ const converter = ortbConverter({
deepSetValue(imp, 'ext.dimensions.slotH', slotEl.offsetHeight);
deepSetValue(imp, 'ext.dimensions.cssMaxW', slotEl.style?.maxWidth);
deepSetValue(imp, 'ext.dimensions.cssMaxH', slotEl.style?.maxHeight);

}
deepSetValue(imp, 'ext.nexx360', bidRequest.params.tagId);
deepSetValue(imp, 'ext.nexx360.tagId', bidRequest.params.tagId);
Expand Down