CORE: disable the requirement for having a url, when enabling renderNow in Renderer #9769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Fawke
approved these changes
Apr 12, 2023
dgirardi
approved these changes
Apr 12, 2023
patmmccann
added a commit
that referenced
this pull request
May 1, 2023
* ZetaGlobalSsp Bid Adapter: provide tagid from params (#9764) * ZetaGlobalSsp: provide tagid from params * fix test --------- Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com> Co-authored-by: Alexey Surovenko <ASurovenko@vdhk6ddf9m.home> * AIDEM Bid Adapter: extended app/site parameters on win notice (#9765) * AIDEM Bid Adapter * Added _spec.js * update * Fix Navigator in _spec.js * Removed timeout handler. * Added publisherId as required bidder params * moved publisherId into site publisher object * Added wpar to environment * Added placementId parameter * added unit tests for the wpar environment object * PlacementId is now a required parameter Added optional rateLimit parameter Added publisherId, siteId, placementId in win notice payload Added unit tests * Revert to optional placementId parameter Added missing semicolons * Extended win notice --------- Co-authored-by: Giovanni Sollazzo <gs@aidem.com> Co-authored-by: darkstar <canazza@wazabit.it> * BrightcomSSP, Brightcom: remove options overide from buildRequests (#9753) * TTD Bid Adapter: add support for video.plcmt and imp.rwdd (#9762) * Update ttdBidAdapter.js * Update ttdBidAdapter_spec.js * Update ttdBidAdapter_spec.js * Update ttdBidAdapter_spec.js * Update ttdBidAdapter_spec.js * Update ttdBidAdapter.js * Update ttdBidAdapter_spec.js * Criteo ID Module: Add error callback for pixel sync call (#9754) Co-authored-by: v.raybaud <v.raybaud@criteo.com> * PubMatic Bid Adapter: native 1.2 support (#9701) * Changes for native 1.2 support * Bug fixes and testacases updation * Changes to include ext and mimes properties of assets and added condition to read len OR length param value * Bug fixes * Bug fix and test cases fix * Test * Test * Update undertoneBidAdapter.js (#9778) * appnexus bid adapter - add gvlids to aliases (#9777) * Update gumgumBidAdapter.js (#9779) * Multiple modules: decouple GVL IDs from storage access control (#9736) * Core: allow restriction of cookies / localStorage through `bidderSettings.*.storageAllowed` * Add test cases * Remove gvlid param from storage manager logic * Refactor every invocation of `getStorageManager` * GVL ID registry * Refactor gdprEnforcement gvlid lookup * fix lint * Remove empty file * Undo #9728 for realVu * Fix typo * Multiple bids in one request to Adrino Adserver (#9742) Co-authored-by: Tomasz Mielcarz <tomasz.mielcarz@adrino.pl> * size map support (#9772) * OpenxOrtbAdapter: add back missing params support for coppa and video (#9782) * Criteo Bid Adapter: Read GPP from ortb2 object (#9775) Add support of GPP consent string when it is present in ortb2 object. * vidazoo Bid Adapter: update support of metaData (#9749) * feat(module): multi size request * fix getUserSyncs added tests * update(module): package-lock.json from master * feat(module): VidazooBidAdapter - send top query params to server * feat: support metaData from server response. * remove forgotten only on spec. --------- Co-authored-by: Udi Talias <udi.talias@gmail.com> Co-authored-by: roman <shmoop207@gmail.com> * Concert Bid Adapter: Enable support for additional userId's (#9780) * collect EIDs for bid request * add ad slot positioning to payload * RPO-2012: Update local storage name-spacing for c_uid (#8) * Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log * RPO-2012: Add check for shared id (#9) * Adds check for sharedId * Updates cookie name * remove trailing comma * [RPO-3152] Enable Support for GPP Consent (#12) * Adds gpp consent integration to concert bid adapter * Update tests to check for gpp consent string param * removes user sync endpoint and tests * updates comment * cleans up consentAllowsPpid function * comment fix * rename variables for clarity * fixes conditional logic for consent allows function (#13) * [RPO-3262] Update getUid function to check for pubcid and sharedid (#14) * Update getUid function to check for pubcid and sharedid * updates adapter version --------- Co-authored-by: antoin <antoin.campbell@voxmedia.com> Co-authored-by: Antoin <antoinfive@gmail.com> * Prebid 7.44.0 release * Increment version to 7.45.0-pre * vidoomy adapter: added bidfloor module (#9784) * Prebid core: fix image assets in converted legacy response (#9752) * Mgid Adapter: update & refactor (#9751) * upd - better support ortb2 - implement getUserSyncs - some refactoring * upd - better support ortb2 - implement getUserSyncs - some refactoring * upd * fix eids import --------- Co-authored-by: gaudeamus <dmitry.markelov@mgid.com> * Various Bid Adapters: point tmax at request object (#9770) * Removed 'CreateEidsArray' import statements, as well as references to it within corresponding functions. Added references to 'userIdAsEids' property as an alternative * Revert "Removed 'CreateEidsArray' import statements, as well as references to it within corresponding functions. Added references to 'userIdAsEids' property as an alternative" This reverts commit f654a5b. * passed all tests * passed tests with bluebillywigAdapter * Impactify bid adapter passed tests * Mediakeys bid adapter passing tests * Sharethrough bid adapter passed tests * Connectad bid adapter passed tests * Added tests back to expectedEids object, and adjusted userIdAsEids array to reflect changes * Yieldmo bid adapter passed tests * Smartadserver bid adapter passed tests * Removed unnecessary reassignment of bidUserId to eids * Removed unnecessary reassignment of bidUserId to eids * Improveddigital bid adapter passed tests * Yieldmo bid adapter passed tests * Sovrn bid adapter passed tests * Ttd bid adapter passed tests * Refactored adapters to draw tmax values from bidderRequest object and ensured they were passing tests * Update nexx360BidAdapter.js * Deleted unrelated ttsBidAdapter file from PR * Deleted unrelated ttdBidAdapter_spec file from PR * add back ttd adapter * add ttd spec flle back * add new line --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * OpenXOrtb Bid Adapter: fix multiformat requests (#9790) * OpenXOrtb: fix multiformat requests * pay attention to feature tags * refactor & cleanup * FreeWheel SSP Bid Adapter: support video context and placement (#9792) * FreeWheel add floor price * FreeWheel code update * FreeWheel-SSP-Adapter: Update to use Vast 4.2 by default * FreeWheel-SSP-Adapter add userIdAsEids support * Freewheel-SSP-Adapter add test for eids * Freewheel SSP Adapter: add prebid version in request * code cleanup * FreeWheel SSP Bid Adapter: support video context and placement * update test * IX Bid Adapter: refactor build request method and ft improves (#9793) Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * AMX ID System: allow cookie storage (#9761) * Update AMXIdSystem logic, allow non-html5 storage, refactor sharedId domainOverride function into library * Fix failing test, bad invocation of getStorageManager * Yahoo ConnectId UserID Module: explicit storage management (#9716) * Explicitly manage storage of ConnectID * Addressed initial PR feedback * Documentation update * Address consent logic issues * Prevent storage of empty object response from UPS * Change storage key to match module name. --------- Co-authored-by: slimkrazy <sam@slimkrazy.com> * Ogury Adapter add device density in bid request (#9796) * Growthcode UserId: Bug fixes & Better Error Catching (#9785) * Remove the cookie storage for data. * Clean up error checking on return JSON data. * Code cleanup * LiveIntent UserId module: Add support for bidswitch and medianet ids (#9703) * Add support for bidswitch id * Add test * Update liveIntentIdSystem_spec.js * Fix test * Add medianet cookie * Change atype from 508 to 3 * Revert version change in package-lock.json * Add bidswitch.com and media.net examples * Customer request: change bidswitch.com to bidswitch.net --------- Co-authored-by: Viktor Dreiling <viktor@Viktors-MBP.fritz.box> Co-authored-by: Viktor Dreiling <viktor@Viktors-MacBook-Pro.local> * Yahoo ConnectId UserID Module: Resolving getStorageManager invocation issue (#9798) * Resolving getStorageManager invocation issue * Lint * MODULE_TYPE -> moduleType * CORE: disable the requirement for having a url, when enabling renderNow in Renderer (#9769) * disable the requirement for having a url, when enabling renderNow in the Renderer * kick off circleci --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * JW Player Video Adapter: Support multiple setup listeners (#9791) * supports multiple setup listeners * adds length check * Pub-X Bid Adapter: adding page url support (#9746) * Pub-X Bid Adapter: adding page url support * Refactored to use site.page * Update pubxBidAdapter.js getting circleci to run --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com> * Magnite Analytics Adapter : add seat non bid handling (#9696) * Return all bids * Adjust findMatch function * Return all buds unit testing * Responds to review comments * Unit test adjustments * Remove extra line for lint * minor changes * doh --------- Co-authored-by: Robert Ray Martinez III <rrmartinez1552@gmail.com> * openxBidAdapter: update to OpenRTB adapter (#9794) * openxBidAdapter: update to OpenRTB adapter * remove skipped tests * IVS Bid Adapter: initial adapter release (#9706) * Add IVS bid adapter * Fix publisherId in test parameters * IVS bid adapter: fix tests (#9807) * Prebid 7.45.0 release * Increment version to 7.46.0-pre * Criteo Bid Adapter: Fix invalid deal property name mapping from bidder response (#9808) Currently, our PBJS adapter code expects to receive a property called 'dealCode' where our bidder emits 'deal' instead. We've updated our backend to temporary emit both dealCode & deal but long term we'd like to align to use 'deal 'across all integrations. * Kargo Bid Adapter: Refactor of bid request (#9731) * pageURL pull from topmostLocation * Kargo: Support for client hints (#9) * Starting SUA support * Kargo: Adding support for client hints * Adding tests for sua * Kargo: Update referer logic * Refactor of Kargo Prebid adapter. * PR comments addressed. * Feedback addressed. * Pr comments addressed. * Continuing refactor of Kargo Bid adapter. * Logic adjustment to exclude values when not present. Relying on server defaults. * Updating unit tests. * PR feedback addressed. * Refactoring bid adapter functions. * PR feedback addressed. * Additional refactoring. * Refactoring for each to use Object entries. * Minor fixes. * Minor fixes. * Minor fixes. * TDID and linting updates * Conflicts resolved with master. * Re-adding raw CRB storage (#14) * Updating shared IDs object name * Fixing missing ad markup * Removing package json changes. Fixing unit tests broken by recent changes. * Linting * send requestCount even when it is 0 for BTO (#18) * Reverting package.json change * Reverting package-lock.json changes * Cleanup * Test cleanup * Test fix Test fix All tests fixed * Adding test for TDID * Resolving merge issue --------- Co-authored-by: Neil Flynn <nflynn@kargo.com> Co-authored-by: Julian Gan <juliangan07@gmail.com> * Criteo Bid Adapter: Map device sua field to user ext sua (#9809) Co-authored-by: v.raybaud <v.raybaud@criteo.com> * Deleted the global.site.cattax field as it is not defined in openrtb 2.5 (#9810) * kueezRtb Bid Adapter: Add support for passing metaData object from server response. (#9815) * AdMatic Bid Adapter: badv added (#9820) * Admatic Bidder Adaptor * Update admaticBidAdapter.md * Update admaticBidAdapter.md * remove floor parameter * Update admaticBidAdapter.js * Admatic Bid Adapter: alias and bid floor features activated * Admatic adapter: host param control changed * Alias name changed. * Revert "Admatic adapter: host param control changed" This reverts commit de7ac85. * added alias feature and host param * Revert "added alias feature and host param" This reverts commit 6ec8f45. * Revert "Alias name changed." This reverts commit 661c54f. * Revert "Admatic Bid Adapter: alias and bid floor features activated" This reverts commit 7a2e0e2. * Revert "Update admaticBidAdapter.js" This reverts commit 7a845b7. * Revert "remove floor parameter" This reverts commit 7a23b05. * Admatic adapter: host param control && Add new Bidder * Revert "Admatic adapter: host param control && Add new Bidder" This reverts commit 3c797b1. * commit new features * Update admaticBidAdapter.js * updated for coverage * sync updated * Update adloader.js * AdMatic Bidder: development of user sync url * Update admaticBidAdapter.js * Set currency for AdserverCurrency: bug fix * Update admaticBidAdapter.js * update * MinuteMediaPlus Bid Adapter: Add support for passing metaData object from server response. (#9816) * Nativo Bid Adapter: Adding UserId support (#9767) * Initial nativoBidAdapter document creation (js, md and spec) * Fulling working prebid using nativoBidAdapter. Support for GDPR and CCPA in user syncs. * Added defult size settings based on the largest ad unit. Added response body validation. Added consent to request url qs params. * Changed bidder endpoint url * Changed double quotes to single quotes. * Reverted package-json.lock to remove modifications from PR * Added optional bidder param 'url' so the ad server can force- match an existing placement * Lint fix. Added space after if. * Added new QS param to send various adUnit data to adapter endpopint * Updated unit test for new QS param * Added qs param to keep track of ad unit refreshes * Updated bidMap key default value * Updated refresh increment logic * Refactored spread operator for IE11 support * Updated isBidRequestValid check * Refactored Object.enties to use Object.keys to fix CircleCI testing errors * Updated bid mapping key creation to prioritize ad unit code over placementId * Added filtering by ad, advertiser and campaign. * Merged master * Added more robust bidDataMap with multiple key access * Deduped filer values * Rolled back package.json * Duped upstream/master's package.lock file ... not sure how it got changed in the first place * Small refactor of filterData length check. Removed comparison with 0 since a length value of 0 is already falsy. * Added bid sizes to request * Fixed function name in spec. Added unit tests. * Added priceFloor module support * Added protection agains empty url parameter * Changed ntv_url QS param to use referrer.location instead of referrer.page * Removed testing 'only' flag * Added ntv_url QS param value validation * Added userId support * Added unit tests, refactored for bugs * Wrapped ajax in try/catch * Added more unit testing * Updated eid check for duplicate values. Removed error logging as we no longer need it. * Removed spec test .only. Fixed unit tests that were breaking. * Added Prebid version to nativo exchange request * Removed unused bidder methods * vidoomy adapter: added userid module (#9795) * KargoBidAdapter: GPP Support (#9812) * support VIDEO feature flag in PubMatic bid adapter (#9744) * Eskimi Bid Adapter: initial adapter release (#9768) * rewrite the adapter to use ortbConverter * Eskimi: fix `isBidRequestValid` * Eskimi: fix request validation tests --------- Co-authored-by: Sekandar <sekandar@eskimi.com> * Update the Conversant adapter to have source.tid to have auctionId (#9822) Co-authored-by: johwier <john.wier@epsilon.com> * MinuteMediaPlus Bid Adapter: Pass gpid to server. (#9830) * IX Bid Adapter: Support for Ad unit specific First Party Data (#9821) * feat: add adunit specific fpd support [PB-1387] * feat: move duplicate code to its function [PB-1387] --------- Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * KueezRtb Bid Adapter: Pass gpid to server. (#9831) * Adnuntius Bid Adapter: Europe endpoint (#9829) * Adnuntius Bid Adapter: Route traffic to euro-servers if GDPR applies. * Tests Added to gdpr applies. * TheMediaGrid: make gridNMBidAdater as alias for gridBidAdapter (#9832) * TheMediaGrid: make gridNMBidAdater as alias for gridBidAdapter * TheMediaGrid: fix alias name * pairId userId submodule: initial commit for pairId submodule (#9662) * add userId submodule for pairId system * [PairIdSystem] add logic to fetch from liveramp cookie * Fix liveramp local storage/cookie key for PairId * addressed PR review comments * Build Process: Disallow it.skip (#9799) * Update realvuAnalyticsAdapter_spec.js * Update axonixBidAdapter_spec.js * Update pubCommonId_spec.js * Update test_index.js * Update test_index.js * Update adagioBidAdapter_spec.js * Update test_index.js * Update test_index.js * Update test_index.js * Update test_index.js * Update openxOrtbBidAdapter_spec.js * Update 1plusXRtdProvider_spec.js * Update pubmaticBidAdapter_spec.js * Pair ID system: fix storageManager invocation (#9833) * Yieldmo Adapter: Send GPP data in bid request. (#9460) * Adding gpp and gpp_sid adding gpp parameters to Banner and Video bids. * Sending gdpr data if no gpp * Refactor * Bidwatch Analytics Adapter: add of the referer for bid won (#9818) * Mediasquare Bid Adapter: add of the referer for onBidWon (#9817) * Mediasquare Bid Adapter: add of the referer for onBidWon * Mediasquare Bid Adapter: replay test * vidoomy adapter: sync url changed (#9834) * Support VIDEO feature flag in AppNexus bid adapter (#9653) * ortbConverter: support video.plcmt (#9840) * Documentation: Add FLEDGE aka Protected Audience API examples (#9839) * Add FLEDGE aka Protected Audience API examples * Remove alias from pbs example * Core: fix spurious warnings on `mergeConfig` (#9704) * Core: fix spurious warnings on `mergeConfig` * Fix sendAllBid config name * Prebid 7.46.0 release * Increment version to 7.47.0-pre * vidoomy adapter: added block module (#9825) * Sending empty array instead of string. (#9846) * RTB house Bid Adapter: fix encoding bug for bid response for native ads (#9850) * RTB hose Bid Adapter: encode URI corecctly using encodeURI instead of encodeURIComponent * Missena Bid Adapter: fix alias (#9849) * add EMTV adapter (#9783) * Criteo Id Module: ensure all kind of privacy strings are sent to backend (#9845) Also adding missing gdpr applies flag * NextMillennium Bd Adapter : add gvlid (#9858) * add gvlid * no change * Prebid 7.47.0 release * Increment version to 7.48.0-pre * Adrino Bid Adapter: banner support added (#9860) * banner support added * test name change * not my test failed * not my test failed --------- Co-authored-by: Tomasz Mielcarz <tomasz.mielcarz@adrino.pl> * Criteo Bid Adapter: Map native assets to slot.ext.assets (#9851) Co-authored-by: v.raybaud <v.raybaud@criteo.com> * Realvu analytics adapter: fix test failures on Edge (#9857) * Realvu analytics adapter: fix test failures on Edge * Remove realVu tests * ORTB2 bcat & badv support + ORTB2 tests (#9871) * AdMatic Bid Adapter: added Video / Banner params (#9856) * Admatic Bidder Adaptor * Update admaticBidAdapter.md * Update admaticBidAdapter.md * remove floor parameter * Update admaticBidAdapter.js * Admatic Bid Adapter: alias and bid floor features activated * Admatic adapter: host param control changed * Alias name changed. * Revert "Admatic adapter: host param control changed" This reverts commit de7ac85. * added alias feature and host param * Revert "added alias feature and host param" This reverts commit 6ec8f45. * Revert "Alias name changed." This reverts commit 661c54f. * Revert "Admatic Bid Adapter: alias and bid floor features activated" This reverts commit 7a2e0e2. * Revert "Update admaticBidAdapter.js" This reverts commit 7a845b7. * Revert "remove floor parameter" This reverts commit 7a23b05. * Admatic adapter: host param control && Add new Bidder * Revert "Admatic adapter: host param control && Add new Bidder" This reverts commit 3c797b1. * commit new features * Update admaticBidAdapter.js * updated for coverage * sync updated * Update adloader.js * AdMatic Bidder: development of user sync url * Update admaticBidAdapter.js * Set currency for AdserverCurrency: bug fix * Update admaticBidAdapter.js * update * admatic adapter video params update * Update admaticBidAdapter.js * update * Update admaticBidAdapter.js * update * update * Update admaticBidAdapter_spec.js * Update admaticBidAdapter.js * Update admaticBidAdapter.js * Revert "Update admaticBidAdapter.js" This reverts commit 1216892. * Revert "Update admaticBidAdapter.js" This reverts commit b1929ec. * Revert "Update admaticBidAdapter_spec.js" This reverts commit 1ca6597. * Revert "update" This reverts commit 689ce9d. * Revert "update" This reverts commit f381a45. * Revert "Update admaticBidAdapter.js" This reverts commit 38fd7ab. * Revert "update" This reverts commit a5316e7. * Revert "Update admaticBidAdapter.js" This reverts commit 60a28ca. * Revert "admatic adapter video params update" This reverts commit 31e69e8. * update * Triplelift Bid Adapter: copying ad unit impression data (#9865) * TL-35335: Cast playbackmethod as array * TL-36204: Copy tid to imp extension obj * Added support for entire ortb2Imp obj * Only setting what exists in ortb2Imp.ext * Added additional test to check copy of entire ext obj * Revert "TL-36204: Copy tid to imp extension object" * TL-36204: Copying ortb2Imp.ext to impression ext obj * Added edge case logic and additional test * recos for tid change * Added spread operator to replace deepClone --------- Co-authored-by: nllerandi3lift <75995508+nllerandi3lift@users.noreply.github.com> Co-authored-by: Nick Llerandi <nllerandi@triplelift.com> * Multiple modules: do not use bidderTimeout as TTL (#9880) * Multiple modules: do not use bidderTimeout as TTL * Fix lint * Grid Bid Adapter: add support for video.plcmt (#9763) * Update gridBidAdapter.js * Update gridBidAdapter_spec.js * Revert "Grid Bid Adapter: add support for video.plcmt (#9763)" (#9882) This reverts commit 2edd264. --------- Co-authored-by: asurovenko-zeta <80847074+asurovenko-zeta@users.noreply.github.com> Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com> Co-authored-by: Alexey Surovenko <ASurovenko@vdhk6ddf9m.home> Co-authored-by: AndreaC <67786179+darkstarac@users.noreply.github.com> Co-authored-by: Giovanni Sollazzo <gs@aidem.com> Co-authored-by: darkstar <canazza@wazabit.it> Co-authored-by: Alexandru <prBigBrother@users.noreply.github.com> Co-authored-by: Vincent <vincent.r06@gmail.com> Co-authored-by: v.raybaud <v.raybaud@criteo.com> Co-authored-by: pm-priyanka-deshmane <107103300+pm-priyanka-deshmane@users.noreply.github.com> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: TM <tomasz.mielcarz@gmail.com> Co-authored-by: Tomasz Mielcarz <tomasz.mielcarz@adrino.pl> Co-authored-by: Taro FURUKAWA <6879289+0tarof@users.noreply.github.com> Co-authored-by: Brian Schmidt <brian.schmidt@openx.com> Co-authored-by: dzhang-criteo <87757739+dzhang-criteo@users.noreply.github.com> Co-authored-by: Saar Amrani <saar120@gmail.com> Co-authored-by: Udi Talias <udi.talias@gmail.com> Co-authored-by: roman <shmoop207@gmail.com> Co-authored-by: Brett Bloxom <38990705+BrettBlox@users.noreply.github.com> Co-authored-by: antoin <antoin.campbell@voxmedia.com> Co-authored-by: Antoin <antoinfive@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: Nisar Thadathil <nisart007@gmail.com> Co-authored-by: JulieLorin <julie@hubvisor.io> Co-authored-by: Gaudeamus <dmitry.markelov@gmail.com> Co-authored-by: gaudeamus <dmitry.markelov@mgid.com> Co-authored-by: Justin Quinn <42960493+Justin-Quinn51@users.noreply.github.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: xwang202 <57196235+xwang202@users.noreply.github.com> Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Nick Jacob <nickbjacob@gmail.com> Co-authored-by: Samuel Adu <samuel.adu@gmail.com> Co-authored-by: slimkrazy <sam@slimkrazy.com> Co-authored-by: Jonathan Nadarajah <50102657+jogury@users.noreply.github.com> Co-authored-by: southern-growthcode <79725079+southern-growthcode@users.noreply.github.com> Co-authored-by: Viktor Dreiling <34981284+3link@users.noreply.github.com> Co-authored-by: Viktor Dreiling <viktor@Viktors-MBP.fritz.box> Co-authored-by: Viktor Dreiling <viktor@Viktors-MacBook-Pro.local> Co-authored-by: Jeremy Sadwith <jeremy@kargo.com> Co-authored-by: olafbuitelaar <olaf.buitelaar@gmail.com> Co-authored-by: Karim Mourra <karim@jwplayer.com> Co-authored-by: yuki <aravow@gmail.com> Co-authored-by: Andrew Slagle <42588549+spotxslagle@users.noreply.github.com> Co-authored-by: Robert Ray Martinez III <rrmartinez1552@gmail.com> Co-authored-by: ivs-mark <128337031+ivs-mark@users.noreply.github.com> Co-authored-by: Léonard Labat <le.labat@criteo.com> Co-authored-by: Neil Flynn <nflynn@kargo.com> Co-authored-by: Julian Gan <juliangan07@gmail.com> Co-authored-by: Antti Ylitepsa <89379237+AYlitepsa@users.noreply.github.com> Co-authored-by: Fatih Kaya <fatih.kaya.84@gmail.com> Co-authored-by: jsfledd <jsfledd@users.noreply.github.com> Co-authored-by: Matt Crute <872334+mbcrute@users.noreply.github.com> Co-authored-by: Mikołaj Robakowski <mrobakowski@users.noreply.github.com> Co-authored-by: Sekandar <sekandar@eskimi.com> Co-authored-by: johnwier <49074029+johnwier@users.noreply.github.com> Co-authored-by: johwier <john.wier@epsilon.com> Co-authored-by: Mikael Lundin <mikael-lundin@users.noreply.github.com> Co-authored-by: TheMediaGrid <44166371+TheMediaGrid@users.noreply.github.com> Co-authored-by: congdu-kun <126609480+congdu-kun@users.noreply.github.com> Co-authored-by: Nayan Savla <nsavla@yieldmo.com> Co-authored-by: Alain Cajuste <63727343+alaincajuste-msq@users.noreply.github.com> Co-authored-by: Laurentiu Badea <laurb9@users.noreply.github.com> Co-authored-by: Nima Sarayan <36764654+nimasrn@users.noreply.github.com> Co-authored-by: kmr <130826954+kmrnpu@users.noreply.github.com> Co-authored-by: Petre Damoc <pdamoc@gmail.com> Co-authored-by: EngageMediaHB <130045707+EngageMediaHB@users.noreply.github.com> Co-authored-by: JacobKlein26 <42449375+JacobKlein26@users.noreply.github.com> Co-authored-by: Piotr Jaworski <109736938+piotrj-rtbh@users.noreply.github.com> Co-authored-by: Patrick Loughrey <ploughrey@triplelift.com> Co-authored-by: nllerandi3lift <75995508+nllerandi3lift@users.noreply.github.com> Co-authored-by: Nick Llerandi <nllerandi@triplelift.com>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
…ow in Renderer (prebid#9769) * disable the requirement for having a url, when enabling renderNow in the Renderer * kick off circleci --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
[ x] Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Right now when you specify a
Rendererfor aBidinstance, which shouldn't load any url, therenderNowcan be set, however this flow currently requires you to set a dummy url, otherwise the check onisRendererRequiredwould fail. I've altered this check so either theurlcould be set or therenderNowflag.