Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgkeywordRtdProvider submodule: support 1plusX SDK #8984

Merged
merged 2 commits into from
Sep 30, 2022
Merged

dgkeywordRtdProvider submodule: support 1plusX SDK #8984

merged 2 commits into from
Sep 30, 2022

Conversation

yki-t
Copy link
Contributor

@yki-t yki-t commented Sep 13, 2022

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

added support for fpid param in LocalStorage: suit for 1plusX spec

Other information

@patmmccann
Copy link
Collaborator

What is happening here? One rtd module is reading from another's endpoint? Can you explain the use case, perhaps in your docs pr?

@patmmccann
Copy link
Collaborator

@bwhisp can you comment?

@yki-t
Copy link
Contributor Author

yki-t commented Sep 20, 2022

@patmmccann

What is happening here? One rtd module is reading from another's endpoint?

Yes. This module was built for connecting to 1plusx, and this patch doesn't change the endpoint.

Can you explain the use case, perhaps in your docs pr?

If 1plusx added fpid to LocalStorage, this patch sends it to 1plusx

@yki-t
Copy link
Contributor Author

yki-t commented Sep 21, 2022

Made fpid optional by 4e30dab

@yki-t
Copy link
Contributor Author

yki-t commented Sep 28, 2022

@patmmccann
Any problems ?

@patmmccann
Copy link
Collaborator

we're waiting on comment from triplelift team. @bwhisp please let us know

@bwhisp
Copy link
Contributor

bwhisp commented Sep 30, 2022

Hello @patmmccann, sorry for the delay
So for me the code looks good
However I noticed the params for dgkeywordRtdProvider changed with the addition of url & disableReadFpid
So it might be a good idea to update the docs (.md file) & the integration example (if it exists) to include these parameters

@patmmccann
Copy link
Collaborator

@yki-t we're happy to merge with the docs update, thanks!

@gggiakas
Copy link

I would like to give some context to the reviewers about this PR.

Digital Garage which is a customer of 1plusX DMP, part of TripleLift, uses its in-house developed Prebid module (https://docs.prebid.org/dev-docs/modules/dgkeywordRtdProvider.html#digital-garage-keyword-module) which was developed before we implement ours.

This modules uses the 1plusX endpoint which provides the targeting information. Then, the targeting information is passed to the bid request.
In this endpoint a user identifier has to be passed in order to identify the user and provide the respective targeting information.
Until August Digital Garage was using an 1plusX snippet that used only a 3rd party cookie.
Then, they upgraded to a newer snippet which sets an ID in the local storage that is called FPID -first party Id.
As a consequence, they wanted to use this additional ID in their prebid module so that they can leverage the presence of this ID (mainly for Safari) for user addressability.

So the aim of this PR is to retrieve from the local storage this ID which is set by the DMP snippet (fpid) and pass it as a query parameter to the endpoint that they call to get the targeting info.

I hope you find this context helpful.

@patmmccann patmmccann merged commit beab665 into prebid:master Sep 30, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* 1plusX SDKによる収集に対応するように修正

* localStrageを読み込むかどうかはparams設定で変更できるように修正

Co-authored-by: mediaconsortium-develop <mediaconsortium-develop@bi.garage.co.jp>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* 1plusX SDKによる収集に対応するように修正

* localStrageを読み込むかどうかはparams設定で変更できるように修正

Co-authored-by: mediaconsortium-develop <mediaconsortium-develop@bi.garage.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants