Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneKey Id Submodule: initial release #8685

Merged
merged 4 commits into from
Aug 31, 2022

Conversation

RomainLofaso
Copy link
Contributor

@RomainLofaso RomainLofaso commented Jul 13, 2022

Type of change

  • Feature

Description of change

This PR adds a userId module for OneKey at https://github.com/prebid/paf-mvp-implementation. The demo currently uses changes that are a superset of this PR. More information about the specifications of the ids and data can be found at https://github.com/prebid/addressability-framework.

Other information

It doesn't appear in the history due to reworks, squashes, and splits of branches but a significant contribution has been done by @bwschmidt on those changes. The current proposal basically renames PAF to OneKey, uses Prebid V7 API and asynchronous API on top of #8366

Pull Request for the documentation: prebid/prebid.github.io#3948

@patmmccann patmmccann changed the title Create Id Submodule for OneKey OneKey Id Submodule: initial release Jul 13, 2022
@patmmccann patmmccann requested a review from jlukas79 July 18, 2022 17:40
while the oneKeyRtdProvider will pass the transmission requests.

Background information:
- [prebid/addressability-framework](https://github.com/prebid/addressability-framework)
Copy link
Collaborator

@patmmccann patmmccann Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my understanding is this is not a stable location, perhaps delete these two lines temporarily or point to the openx fork or point to the moved repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Duplicated answer from #8686 (comment))

For now, there is no other location. As far as I know, nothing is planned for changing them. If later, those locations change, we will update this document accordingly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a deal breaker for merging. You must delete these references.

The prebid board voted to allow for the timely transition of these repos to some other org. I am not sure what org that will be, but again, these are not stable locations.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomainLofaso it seems we're approaching the finish line here, looking forward to merging once the branding changes are complete in this pr

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @patmmccann ,

Sorry, I took time to do this change. Briefly, my team wasn't aware of this aspect of the vote. After your feedback, we clarified this point. Finally, @BasileLeparmentier has moved the repositories to another workspace so that I can update the PR with a good location.

This is done in the last commit.

Thanks

@patmmccann
Copy link
Collaborator

Can you link to the docs repo pr as well?

@RomainLofaso
Copy link
Contributor Author

RomainLofaso commented Aug 8, 2022

Can you link to the docs repo pr as well?

Hi @patmmccann
Done. Here is the pull request for the documentation: prebid/prebid.github.io#3948

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo references

while the oneKeyRtdProvider will pass the transmission requests.

Background information:
- [prebid/addressability-framework](https://github.com/prebid/addressability-framework)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a deal breaker for merging. You must delete these references.

The prebid board voted to allow for the timely transition of these repos to some other org. I am not sure what org that will be, but again, these are not stable locations.

RomainLofaso added a commit to criteo-forks/prebid.github.io that referenced this pull request Aug 29, 2022
@patmmccann patmmccann merged commit 2543467 into prebid:master Aug 31, 2022
bretg pushed a commit to prebid/prebid.github.io that referenced this pull request Oct 6, 2022
* Add the OneKey Id sub-module and the OneKey RTD module

User Id sub-module: prebid/Prebid.js#8685
RTD module: prebid/Prebid.js#8686

* Update the locations of the OneKey repositories
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* Create Id Submodule for OneKey

* Fix the 'decode' of OneKey Id

* Refine the documentation of the OneKey Id Sub-Module

* Update locations of the OneKey repositories in the Id sub-module doc
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* Create Id Submodule for OneKey

* Fix the 'decode' of OneKey Id

* Refine the documentation of the OneKey Id Sub-Module

* Update locations of the OneKey repositories in the Id sub-module doc
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* Add the OneKey Id sub-module and the OneKey RTD module

User Id sub-module: prebid/Prebid.js#8685
RTD module: prebid/Prebid.js#8686

* Update the locations of the OneKey repositories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants