OneKey Id Submodule: initial release #8685
Conversation
patmmccann
changed the title
modules/oneKeyIdSystem.md
Outdated
| while the oneKeyRtdProvider will pass the transmission requests. | ||
|
|
||
| Background information: | ||
| - [prebid/addressability-framework](https://github.com/prebid/addressability-framework) |
There was a problem hiding this comment.
my understanding is this is not a stable location, perhaps delete these two lines temporarily or point to the openx fork or point to the moved repo?
There was a problem hiding this comment.
(Duplicated answer from #8686 (comment))
For now, there is no other location. As far as I know, nothing is planned for changing them. If later, those locations change, we will update this document accordingly.
There was a problem hiding this comment.
This is a deal breaker for merging. You must delete these references.
The prebid board voted to allow for the timely transition of these repos to some other org. I am not sure what org that will be, but again, these are not stable locations.
There was a problem hiding this comment.
@RomainLofaso it seems we're approaching the finish line here, looking forward to merging once the branding changes are complete in this pr
There was a problem hiding this comment.
Hello @patmmccann ,
Sorry, I took time to do this change. Briefly, my team wasn't aware of this aspect of the vote. After your feedback, we clarified this point. Finally, @BasileLeparmentier has moved the repositories to another workspace so that I can update the PR with a good location.
This is done in the last commit.
Thanks
|
Can you link to the docs repo pr as well? |
User Id sub-module: prebid/Prebid.js#8685 RTD module: prebid/Prebid.js#8686
Hi @patmmccann |
RomainLofaso
force-pushed
the
onekey-id-submodule
branch
from
3430099
to
64cae03
Compare
modules/oneKeyIdSystem.md
Outdated
| while the oneKeyRtdProvider will pass the transmission requests. | ||
|
|
||
| Background information: | ||
| - [prebid/addressability-framework](https://github.com/prebid/addressability-framework) |
There was a problem hiding this comment.
This is a deal breaker for merging. You must delete these references.
The prebid board voted to allow for the timely transition of these repos to some other org. I am not sure what org that will be, but again, these are not stable locations.
User Id sub-module: prebid/Prebid.js#8685 RTD module: prebid/Prebid.js#8686
RomainLofaso
force-pushed
the
onekey-id-submodule
branch
from
64cae03
to
2b5f314
Compare
* Add the OneKey Id sub-module and the OneKey RTD module User Id sub-module: prebid/Prebid.js#8685 RTD module: prebid/Prebid.js#8686 * Update the locations of the OneKey repositories
* Create Id Submodule for OneKey * Fix the 'decode' of OneKey Id * Refine the documentation of the OneKey Id Sub-Module * Update locations of the OneKey repositories in the Id sub-module doc
* Create Id Submodule for OneKey * Fix the 'decode' of OneKey Id * Refine the documentation of the OneKey Id Sub-Module * Update locations of the OneKey repositories in the Id sub-module doc
* Add the OneKey Id sub-module and the OneKey RTD module User Id sub-module: prebid/Prebid.js#8685 RTD module: prebid/Prebid.js#8686 * Update the locations of the OneKey repositories
Type of change
Description of change
This PR adds a userId module for OneKey at https://github.com/prebid/paf-mvp-implementation. The demo currently uses changes that are a superset of this PR. More information about the specifications of the ids and data can be found at https://github.com/prebid/addressability-framework.
Other information
It doesn't appear in the history due to reworks, squashes, and splits of branches but a significant contribution has been done by @bwschmidt on those changes. The current proposal basically renames PAF to OneKey, uses Prebid V7 API and asynchronous API on top of #8366
Pull Request for the documentation: prebid/prebid.github.io#3948